[BugFix] Fix disk metrics bug when partition name does not end with number. (backport #42723) #42741
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![mergify[bot]](https://avatars.githubusercontent.com/in/10562?s=60&v=4){kind=small}
…umber. (#42723) When the partition name does not end with a number, it is incorrect to trim the suffix number to get the device name. For example, the device name is `nvme0n1` and the partition name is `nvme0n1p1`, in this case the device name generated from the partition is `nvme0n1p` and using this name to find statistics from `/proc/diskstats` will fail. Signed-off-by: gengjun-git <gengjun@starrocks.com> (cherry picked from commit 762ca68)
23 tasks
gengjun-git
approved these changes
Mar 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I'm doing:
When the partition name does not end with a number, it is incorrect to trim the suffix number to get the device name. For example, the device name is
nvme0n1and the partition name isnvme0n1p1, in this case the device name generated from the partition isnvme0n1pand using this name to find statistics from/proc/diskstatswill fail.What I'm doing:
Do not trim the partition name, and show the device partition statistic.
Fixes #29093
What type of PR is this:
Does this PR entail a change in behavior?
If yes, please specify the type of change:
Checklist:
Bugfix cherry-pick branch check:
This is an automatic backport of pull request #42723 done by [Mergify](https://mergify.com). ## Why I'm doing: When the partition name does not end with a number, it is incorrect to trim the suffix number to get the device name. For example, the device name is `nvme0n1` and the partition name is `nvme0n1p1`, in this case the device name generated from the partition is `nvme0n1p` and using this name to find statistics from `/proc/diskstats` will fail.
What I'm doing:
Do not trim the partition name, and show the device partition statistic.
Fixes #29093
What type of PR is this:
Does this PR entail a change in behavior?
If yes, please specify the type of change:
Checklist: