Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BugFix] fix drop system table #43552

Merged
merged 1 commit into from Apr 3, 2024
Merged

[BugFix] fix drop system table #43552

merged 1 commit into from Apr 3, 2024

Conversation

mofeiatwork
Copy link
Contributor

Why I'm doing:

What I'm doing:

  • Drop system table should be denied

Fixes #issue

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.3
    • 3.2
    • 3.1
    • 3.0
    • 2.5

@mofeiatwork
fix drop system table
1225481 
Signed-off-by: Murphy <mofei@starrocks.com>
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Apr 2, 2024

Quality Gate Passed Quality Gate passed

Issues
7 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 2, 2024

[FE Incremental Coverage Report]

✅ pass : 3 / 3 (100.00%)

file detail

path covered_line new_line coverage not_covered_line_detail
🔵 com/starrocks/server/LocalMetastore.java 3 3 100.00% []

@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 2, 2024

[BE Incremental Coverage Report]

✅ pass : 0 / 0 (0%)

@mofeiatwork mofeiatwork merged commit ae53be7 into StarRocks:main Apr 3, 2024
57 checks passed
@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 3, 2024

@Mergifyio backport branch-3.3

@github-actions github-actions bot removed the 3.3 label Apr 3, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 3, 2024

@Mergifyio backport branch-3.2

@github-actions github-actions bot removed the 3.2 label Apr 3, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 3, 2024

@Mergifyio backport branch-3.1

@github-actions github-actions bot removed the 3.1 label Apr 3, 2024
@mergify Mergify
Copy link
Contributor

mergify bot commented Apr 3, 2024 •
edited

backport branch-3.3

✅ Backports have been created

@mergify Mergify
Copy link
Contributor

mergify bot commented Apr 3, 2024 •
edited

backport branch-3.2

✅ Backports have been created

@mergify Mergify
Copy link
Contributor

mergify bot commented Apr 3, 2024 •
edited

backport branch-3.1

✅ Backports have been created

@mergify mergify bot mentioned this pull request Apr 3, 2024
Merged
42 tasks
mergify bot pushed a commit that referenced this pull request Apr 3, 2024
@mofeiatwork @mergify
[BugFix] fix drop system table (#43552)
d645d90 
Signed-off-by: Murphy <mofei@starrocks.com>
(cherry picked from commit ae53be7)
@mergify mergify bot mentioned this pull request Apr 3, 2024
Merged
42 tasks
mergify bot pushed a commit that referenced this pull request Apr 3, 2024
@mofeiatwork @mergify
[BugFix] fix drop system table (#43552)
f1ce6a1 
Signed-off-by: Murphy <mofei@starrocks.com>
(cherry picked from commit ae53be7)
mergify bot pushed a commit that referenced this pull request Apr 3, 2024
@mofeiatwork @mergify
[BugFix] fix drop system table (#43552)
bd324b8 
Signed-off-by: Murphy <mofei@starrocks.com>
(cherry picked from commit ae53be7)
@mergify mergify bot mentioned this pull request Apr 3, 2024
Merged
42 tasks
wanpengfei-git pushed a commit that referenced this pull request Apr 3, 2024
@mergify @mofeiatwork
[BugFix] fix drop system table (backport #43552) (#43554)
c8dd334 
Co-authored-by: Murphy <96611012+mofeiatwork@users.noreply.github.com>
wanpengfei-git pushed a commit that referenced this pull request Apr 3, 2024
@mergify @mofeiatwork
[BugFix] fix drop system table (backport #43552) (#43555)
2d308fd 
Co-authored-by: Murphy <96611012+mofeiatwork@users.noreply.github.com>
wanpengfei-git pushed a commit that referenced this pull request Apr 3, 2024
@mergify @mofeiatwork
[BugFix] fix drop system table (backport #43552) (#43556)
c9263bc 
Co-authored-by: Murphy <96611012+mofeiatwork@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dirtysalt dirtysalt dirtysalt approved these changes

@chaoyli chaoyli chaoyli approved these changes

@allencelerdata allencelerdata allencelerdata approved these changes

Assignees

@mofeiatwork mofeiatwork

Labels
3.1-merged 3.2-merged 3.3-merged behavior_changed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@mofeiatwork @dirtysalt @chaoyli @allencelerdata