-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BugFix] fix race condition issue about persistent index's l0 #43569
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add test case |
|
|
Signed-off-by: luohaha <18810541851@163.com>
luohaha
force-pushed
the
fix-persistent-index-conc
branch
from
April 3, 2024 07:02
78dafe4
to
1850909
Compare
luohaha
force-pushed
the
fix-persistent-index-conc
branch
from
April 3, 2024 08:17
cca2d8c
to
d17a395
Compare
trueeyu
reviewed
Apr 7, 2024
[FE Incremental Coverage Report]✅ pass : 0 / 0 (0%) |
[BE Incremental Coverage Report]✅ pass : 45 / 45 (100.00%) file detail
|
trueeyu
reviewed
Apr 7, 2024
trueeyu
reviewed
Apr 7, 2024
trueeyu
reviewed
Apr 7, 2024
trueeyu
approved these changes
Apr 8, 2024
Will 2.5/3.0 have the problem? |
@Mergifyio backport branch-3.0 |
@Mergifyio backport branch-2.5 |
✅ Backports have been created
|
✅ Backports have been created
|
✅ Backports have been created
|
✅ Backports have been created
|
✅ Backports have been created
|
mergify bot
pushed a commit
that referenced
this pull request
Apr 8, 2024
Signed-off-by: luohaha <18810541851@163.com> (cherry picked from commit 05a6911)
mergify bot
pushed a commit
that referenced
this pull request
Apr 8, 2024
Signed-off-by: luohaha <18810541851@163.com> (cherry picked from commit 05a6911) # Conflicts: # be/src/storage/persistent_index.cpp
mergify bot
pushed a commit
that referenced
this pull request
Apr 8, 2024
Signed-off-by: luohaha <18810541851@163.com> (cherry picked from commit 05a6911) # Conflicts: # be/src/storage/persistent_index.cpp
mergify bot
pushed a commit
that referenced
this pull request
Apr 8, 2024
Signed-off-by: luohaha <18810541851@163.com> (cherry picked from commit 05a6911) # Conflicts: # be/src/storage/persistent_index.cpp # be/test/storage/tablet_updates_test.cpp
This was referenced Apr 8, 2024
mergify bot
pushed a commit
that referenced
this pull request
Apr 8, 2024
Signed-off-by: luohaha <18810541851@163.com> (cherry picked from commit 05a6911) # Conflicts: # be/src/storage/persistent_index.cpp # be/test/storage/tablet_updates_test.cpp
42 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I'm doing:
In apply thread, persistent index will be modified and
_l0
can be destroy and re-create. At the same time, another thread may visit_l0
byPersistentIndex::memory_usage
.There will be race condition issue here.
What I'm doing:
Add atomic val
_memory_usage
, calculate it each time when persistent index been modified, andPersistentIndex::memory_usage
is only need to return_memory_usage
, which is thread safe.What type of PR is this:
Does this PR entail a change in behavior?
If yes, please specify the type of change:
Checklist:
Bugfix cherry-pick branch check: