Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BugFix] fix race condition issue about persistent index's l0 #43569

Merged
merged 3 commits into from
Apr 8, 2024

Conversation

luohaha
Copy link
Contributor

@luohaha luohaha commented Apr 3, 2024

Why I'm doing:

In apply thread, persistent index will be modified and _l0 can be destroy and re-create. At the same time, another thread may visit _l0 by PersistentIndex::memory_usage.
There will be race condition issue here.

What I'm doing:

Add atomic val _memory_usage, calculate it each time when persistent index been modified, and PersistentIndex::memory_usage is only need to return _memory_usage, which is thread safe.

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.3
    • 3.2
    • 3.1
    • 3.0
    • 2.5

@luohaha luohaha requested a review from a team as a code owner April 3, 2024 03:39
@trueeyu
Copy link
Contributor

trueeyu commented Apr 3, 2024

Add test case

@trueeyu
Copy link
Contributor

trueeyu commented Apr 3, 2024

        std::unique_lock wrlock(_lock);
        _l1_vec.emplace_back(std::move(l1_st).value());
        _l1_merged_num.emplace_back(1);
    }
    // clear l0
    _l0->clear();   please check this code

@trueeyu
Copy link
Contributor

trueeyu commented Apr 3, 2024

    new_l1_vec.emplace_back(std::move(l1_st).value());
    new_l1_merged_num.emplace_back((merge_l1_end_idx - merge_l1_start_idx) * merge_num);
    {
        std::unique_lock wrlock(_lock);
        _l1_vec.swap(new_l1_vec);
        _l1_merged_num.swap(new_l1_merged_num);
    }
    _l0->clear();  //here

Signed-off-by: luohaha <18810541851@163.com>
Signed-off-by: luohaha <18810541851@163.com>
Signed-off-by: luohaha <18810541851@163.com>
Copy link

github-actions bot commented Apr 7, 2024

[FE Incremental Coverage Report]

pass : 0 / 0 (0%)

Copy link

github-actions bot commented Apr 7, 2024

[BE Incremental Coverage Report]

pass : 45 / 45 (100.00%)

file detail

path covered_line new_line coverage not_covered_line_detail
🔵 be/src/storage/persistent_index.cpp 38 38 100.00% []
🔵 be/src/storage/primary_index.cpp 2 2 100.00% []
🔵 be/src/storage/persistent_index.h 1 1 100.00% []
🔵 be/src/storage/tablet_updates.cpp 4 4 100.00% []

@trueeyu
Copy link
Contributor

trueeyu commented Apr 8, 2024

Will 2.5/3.0 have the problem?

@github-actions github-actions bot added the 3.0 label Apr 8, 2024
@github-actions github-actions bot removed the 3.1 label Apr 8, 2024
Copy link

github-actions bot commented Apr 8, 2024

@Mergifyio backport branch-3.0

@github-actions github-actions bot removed the 3.0 label Apr 8, 2024
Copy link

github-actions bot commented Apr 8, 2024

@Mergifyio backport branch-2.5

@github-actions github-actions bot removed the 2.5 label Apr 8, 2024
Copy link
Contributor

mergify bot commented Apr 8, 2024

backport branch-3.3

✅ Backports have been created

Copy link
Contributor

mergify bot commented Apr 8, 2024

backport branch-3.2

✅ Backports have been created

Copy link
Contributor

mergify bot commented Apr 8, 2024

backport branch-3.1

✅ Backports have been created

Copy link
Contributor

mergify bot commented Apr 8, 2024

backport branch-3.0

✅ Backports have been created

Copy link
Contributor

mergify bot commented Apr 8, 2024

backport branch-2.5

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Apr 8, 2024
Signed-off-by: luohaha <18810541851@163.com>
(cherry picked from commit 05a6911)
mergify bot pushed a commit that referenced this pull request Apr 8, 2024
Signed-off-by: luohaha <18810541851@163.com>
(cherry picked from commit 05a6911)

# Conflicts:
#	be/src/storage/persistent_index.cpp
mergify bot pushed a commit that referenced this pull request Apr 8, 2024
Signed-off-by: luohaha <18810541851@163.com>
(cherry picked from commit 05a6911)

# Conflicts:
#	be/src/storage/persistent_index.cpp
mergify bot pushed a commit that referenced this pull request Apr 8, 2024
Signed-off-by: luohaha <18810541851@163.com>
(cherry picked from commit 05a6911)

# Conflicts:
#	be/src/storage/persistent_index.cpp
#	be/test/storage/tablet_updates_test.cpp
mergify bot pushed a commit that referenced this pull request Apr 8, 2024
Signed-off-by: luohaha <18810541851@163.com>
(cherry picked from commit 05a6911)

# Conflicts:
#	be/src/storage/persistent_index.cpp
#	be/test/storage/tablet_updates_test.cpp
wanpengfei-git pushed a commit that referenced this pull request Apr 8, 2024
wanpengfei-git pushed a commit that referenced this pull request Apr 8, 2024
#43569) (#43719)

Signed-off-by: Yixin Luo <18810541851@163.com>
Co-authored-by: Yixin Luo <18810541851@163.com>
wanpengfei-git pushed a commit that referenced this pull request Apr 8, 2024
#43569) (#43720)

Signed-off-by: Yixin Luo <18810541851@163.com>
Co-authored-by: Yixin Luo <18810541851@163.com>
wanpengfei-git pushed a commit that referenced this pull request Apr 8, 2024
#43569) (#43722)

Signed-off-by: Yixin Luo <18810541851@163.com>
Co-authored-by: Yixin Luo <18810541851@163.com>
wanpengfei-git pushed a commit that referenced this pull request Apr 8, 2024
#43569) (#43721)

Signed-off-by: Yixin Luo <18810541851@163.com>
Co-authored-by: Yixin Luo <18810541851@163.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants