Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BugFix] Fix race condition issue in PrimaryIndex::memory_usage() #44034

Merged
merged 4 commits into from
Apr 15, 2024

Conversation

sevev
Copy link
Contributor

@sevev sevev commented Apr 14, 2024

Why I'm doing:

There are two race condition issue when call function PrimaryIndex::memory_usage():

  1. If rebuild primary index in apply compaction phase, we will clear primary index which is a read-write conflict with memory_usage().
  2. If the memory is not enough, we may not load all bloom filter of persistent index into memory but only load the shard we needed and there are some nullptr in _bf_vec. When we call function _memory_usage(), we will get nullptr exception.

What I'm doing:

Fix the bug.

Fixes #issue

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.3
    • 3.2
    • 3.1
    • 3.0
    • 2.5

Signed-off-by: zhangqiang <qiangzh95@gmail.com>
@sevev sevev requested a review from a team as a code owner April 14, 2024 07:37
@mergify mergify bot assigned sevev Apr 14, 2024
Signed-off-by: zhangqiang <qiangzh95@gmail.com>
Signed-off-by: zhangqiang <qiangzh95@gmail.com>
Signed-off-by: zhangqiang <qiangzh95@gmail.com>
Copy link

[FE Incremental Coverage Report]

pass : 0 / 0 (0%)

Copy link

[BE Incremental Coverage Report]

pass : 14 / 14 (100.00%)

file detail

path covered_line new_line coverage not_covered_line_detail
🔵 be/src/storage/primary_index.cpp 12 12 100.00% []
🔵 be/src/storage/persistent_index.h 2 2 100.00% []

@wyb wyb merged commit d3ad232 into StarRocks:main Apr 15, 2024
53 checks passed
Copy link

@Mergifyio backport branch-3.3

Copy link

@Mergifyio backport branch-3.2

Copy link

@Mergifyio backport branch-3.1

@github-actions github-actions bot removed the 3.1 label Apr 15, 2024
Copy link
Contributor

mergify bot commented Apr 15, 2024

backport branch-3.3

✅ Backports have been created

Copy link
Contributor

mergify bot commented Apr 15, 2024

backport branch-3.2

✅ Backports have been created

Copy link
Contributor

mergify bot commented Apr 15, 2024

backport branch-3.1

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Apr 15, 2024
…4034)

Signed-off-by: zhangqiang <qiangzh95@gmail.com>
(cherry picked from commit d3ad232)
mergify bot pushed a commit that referenced this pull request Apr 15, 2024
…4034)

Signed-off-by: zhangqiang <qiangzh95@gmail.com>
(cherry picked from commit d3ad232)
mergify bot pushed a commit that referenced this pull request Apr 15, 2024
…4034)

Signed-off-by: zhangqiang <qiangzh95@gmail.com>
(cherry picked from commit d3ad232)
wanpengfei-git pushed a commit that referenced this pull request Apr 15, 2024
…ckport #44034) (#44044)

Co-authored-by: zhangqiang <qiangzh95@gmail.com>
wanpengfei-git pushed a commit that referenced this pull request Apr 15, 2024
…ckport #44034) (#44045)

Co-authored-by: zhangqiang <qiangzh95@gmail.com>
wanpengfei-git pushed a commit that referenced this pull request Apr 15, 2024
…ckport #44034) (#44043)

Co-authored-by: zhangqiang <qiangzh95@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants