Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BugFix] Fix struct ordinal index error #44608

Merged
merged 1 commit into from
Apr 24, 2024
Merged

[BugFix] Fix struct ordinal index error #44608

merged 1 commit into from
Apr 24, 2024

Conversation

Seaven
Copy link
Contributor

@Seaven Seaven commented Apr 23, 2024 •
edited
Loading

Why I'm doing:

access_iters[0] may doesn't read data when use late_materializa, so the ordinal index is error

What I'm doing:

Follow: #44294

Fixes https://github.com/StarRocks/StarRocksTest/issues/7150

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.3
    • 3.2
    • 3.1
    • 3.0
    • 2.5

@Seaven
[BugFix] Fix struct ordinal index error
f6f0344 
Signed-off-by: Seaven <seaven_7@qq.com>
@Seaven Seaven requested a review from a team as a code owner April 23, 2024 09:28
@mergify mergify bot assigned Seaven Apr 23, 2024
@github-actions GitHub Actions
Copy link

[FE Incremental Coverage Report]

✅ pass : 0 / 0 (0%)

@github-actions GitHub Actions
Copy link

[BE Incremental Coverage Report]

❌ fail : 8 / 12 (66.67%)

file detail

path covered_line new_line coverage not_covered_line_detail
🔵 be/src/storage/rowset/struct_column_iterator.cpp 8 12 66.67% [263, 269, 270, 271]

kangkaisen pushed a commit that referenced this pull request Apr 24, 2024
@Seaven
[BugFix] Fix get struct ordinal index error (backport #44608) (#44604)
d3ccad5 
Signed-off-by: Seaven <seaven_7@qq.com>
mergify bot pushed a commit that referenced this pull request Apr 24, 2024
@Seaven @mergify
[BugFix] Fix get struct ordinal index error (backport #44608) (#44604)
fa10d71 
Signed-off-by: Seaven <seaven_7@qq.com>
(cherry picked from commit d3ccad5)

# Conflicts:
#	be/src/storage/rowset/struct_column_iterator.cpp
Seaven added a commit to Seaven/starrocks that referenced this pull request Apr 24, 2024
@Seaven
[BugFix] Fix get struct ordinal index error (backport StarRocks#44608) (
9879011 
StarRocks#44604)

Signed-off-by: Seaven <seaven_7@qq.com>
Seaven added a commit to Seaven/starrocks that referenced this pull request Apr 24, 2024
@Seaven
[BugFix] Fix get struct ordinal index error (backport StarRocks#44608) (
53c4c36 
StarRocks#44604)

Signed-off-by: Seaven <seaven_7@qq.com>
kangkaisen pushed a commit that referenced this pull request Apr 24, 2024
@Seaven
[BugFix] Fix get struct ordinal index error (backport #44608) (#44667)
34f131b 
Signed-off-by: Seaven <seaven_7@qq.com>
@kangkaisen kangkaisen merged commit 94f8067 into StarRocks:main Apr 24, 2024
79 of 84 checks passed
@github-actions GitHub Actions
Copy link

@Mergifyio backport branch-3.3

@github-actions github-actions bot removed the 3.3 label Apr 24, 2024
@mergify Mergify
Copy link
Contributor

mergify bot commented Apr 24, 2024 •
edited
Loading

backport branch-3.3

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Apr 24, 2024
@Seaven @mergify
[BugFix] Fix struct ordinal index error (#44608)
32291f0 
Signed-off-by: Seaven <seaven_7@qq.com>
(cherry picked from commit 94f8067)
@mergify mergify bot mentioned this pull request Apr 24, 2024
Merged
42 tasks
wanpengfei-git pushed a commit that referenced this pull request Apr 24, 2024
@mergify @Seaven
[BugFix] Fix struct ordinal index error (backport #44608) (#44683)
e2f5f8e 
Co-authored-by: Seaven <seaven_7@qq.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@starrocks-cr starrocks-cr[bot] starrocks-cr left review comments

@sduzh sduzh sduzh approved these changes

@kangkaisen kangkaisen kangkaisen approved these changes

@stdpain stdpain stdpain approved these changes

Assignees

@Seaven Seaven

Labels
3.1-merged 3.2-merged 3.3-merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Seaven @sduzh @kangkaisen @stdpain