Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Enhancement] Remove internal_service_async_thread_num #45029

Merged
merged 2 commits into from
May 6, 2024
Merged

[Enhancement] Remove internal_service_async_thread_num #45029

merged 2 commits into from
May 6, 2024

Conversation

rickif
Copy link
Contributor

@rickif rickif commented Apr 30, 2024 •
edited

Why I'm doing:

What I'm doing:

This PR removes the _async_thread_pool limitation. With the new implementation, the size of the thread pool _async_thread_pool is determined by the number of simultaneous tasks submitted by the FE.

Fixes #issue

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.3
    • 3.2
    • 3.1
    • 3.0
    • 2.5

@github-actions github-actions bot added the 2.5 label Apr 30, 2024
@mergify mergify bot assigned rickif Apr 30, 2024
@rickif
internal_service: remove internal_service_pool
061f0f5 
Signed-off-by: ricky <rickif@qq.com>
@rickif rickif force-pushed the feat/routine-load-thread-pool branch from d0d8d73 to 061f0f5 Compare April 30, 2024 08:48
@rickif
*: reset _load_rpc_pool
09c54d4 
Signed-off-by: ricky <rickif@qq.com>
@wyb wyb enabled auto-merge (squash) May 6, 2024 03:28
@wyb wyb merged commit 8f30c5e into StarRocks:branch-2.5 May 6, 2024
31 checks passed
@rickif rickif deleted the feat/routine-load-thread-pool branch May 6, 2024 07:15
@rickif
Copy link
Contributor Author

rickif commented May 6, 2024

@Mergifyio backport branch-3.0

@mergify Mergify
Copy link
Contributor

mergify bot commented May 6, 2024 •
edited

backport branch-3.0

🛑 Command backport branch-3.0 cancelled because of a new backport command with different arguments

@rickif
Copy link
Contributor Author

rickif commented May 7, 2024

@Mergifyio backport branch-3.0

@mergify Mergify
Copy link
Contributor

mergify bot commented May 7, 2024 •
edited

backport branch-3.0

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request May 7, 2024
@rickif @mergify
[Enhancement] Remove internal_service_async_thread_num (#45029)
5bf60a7 
Signed-off-by: ricky <rickif@qq.com>
(cherry picked from commit 8f30c5e)

# Conflicts:
#	be/src/common/config.h
#	be/src/runtime/exec_env.cpp
#	be/src/runtime/exec_env.h
#	be/src/service/internal_service.h
@mergify mergify bot mentioned this pull request May 7, 2024
Closed
42 tasks
@rickif rickif mentioned this pull request May 7, 2024
Merged
24 tasks
wyb pushed a commit that referenced this pull request May 7, 2024
@rickif
[Enhancement] Remove internal_service_async_thread_num (branch-3.0) (…
a339044 
…backport #45029) (#45183)

Signed-off-by: ricky <rickif@qq.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wyb wyb wyb approved these changes

Assignees

@rickif rickif

Labels
2.5 3.0-merged 3.0 behavior_changed version:2.5.21
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@rickif @wyb