Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] Support use table_name to filter scan in information_schema.tables (backport #45351) #45392

Merged
merged 1 commit into from
May 10, 2024

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented May 9, 2024

Why I'm doing:

What I'm doing:

Fixes #issue

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.3
    • 3.2
    • 3.1
    • 3.0
    • 2.5

This is an automatic backport of pull request #45351 done by [Mergify](https://mergify.com). ## Why I'm doing:

What I'm doing:

Fixes #issue

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

@mergify mergify bot added the conflicts label May 9, 2024
Copy link
Contributor Author

mergify bot commented May 9, 2024

Cherry-pick of 948e48f has failed:

On branch mergify/bp/branch-2.5/pr-45351
Your branch is up to date with 'origin/branch-2.5'.

You are currently cherry-picking commit 948e48f281.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   gensrc/thrift/FrontendService.thrift

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   be/src/exec/vectorized/schema_scanner/schema_tables_scanner.cpp
	both modified:   fe/fe-core/src/main/java/com/starrocks/service/InformationSchemaDataSource.java

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

@wanpengfei-git wanpengfei-git enabled auto-merge (squash) May 9, 2024 15:34
@mergify mergify bot closed this May 9, 2024
auto-merge was automatically disabled May 9, 2024 15:34

Pull request was closed

Copy link
Contributor Author

mergify bot commented May 9, 2024

@mergify[bot]: Backport conflict, please reslove the conflict and resubmit the pr

@mergify mergify bot deleted the mergify/bp/branch-2.5/pr-45351 branch May 9, 2024 15:35
@HangyuanLiu HangyuanLiu restored the mergify/bp/branch-2.5/pr-45351 branch May 10, 2024 06:50
@HangyuanLiu HangyuanLiu reopened this May 10, 2024
@wanpengfei-git wanpengfei-git enabled auto-merge (squash) May 10, 2024 06:50
@HangyuanLiu HangyuanLiu force-pushed the mergify/bp/branch-2.5/pr-45351 branch from 46d0130 to 71d72ed Compare May 10, 2024 07:31
…hema.tables (#45351)

Signed-off-by: HangyuanLiu <460660596@qq.com>
(cherry picked from commit 948e48f)

# Conflicts:
#	be/src/exec/vectorized/schema_scanner/schema_tables_scanner.cpp
#	fe/fe-core/src/main/java/com/starrocks/service/InformationSchemaDataSource.java
@HangyuanLiu HangyuanLiu force-pushed the mergify/bp/branch-2.5/pr-45351 branch from 71d72ed to 3aadb8e Compare May 10, 2024 07:33
Copy link

sonarcloud bot commented May 10, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
C Maintainability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

@wanpengfei-git wanpengfei-git merged commit 0dbb896 into branch-2.5 May 10, 2024
32 of 34 checks passed
@wanpengfei-git wanpengfei-git deleted the mergify/bp/branch-2.5/pr-45351 branch May 10, 2024 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants