[Enhancement] Support use table_name to filter scan in information_schema.tables #45351
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: HangyuanLiu <460660596@qq.com>
# Conflicts: # be/src/exec/schema_scanner/schema_tables_scanner.cpp
![starrocks-cr[bot]](https://avatars.githubusercontent.com/in/404334?s=60&v=4){kind=small}
| if (table.isNativeTableOrMaterializedView()) { | ||
| tableLocker.unLockTablesWithIntensiveDbLock(db, Lists.newArrayList(((OlapTable) table).getId()), | ||
| LockType.READ); | ||
| } | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
The most risky bug in this code is:
Potential deadlock due to nested locking mechanisms without a consistent lock acquisition order.
You can modify the code like this:
// Before introducing new lock (tableLocker) inside the loop for tables,
// ensure there's a global policy or mechanism to avoid deadlocks.
// One approach could be ensuring that locks are always acquired in a consistent order and possibly reducing the scope where locks are held.
// For example, rather than acquiring a second lock inside the loop while still holding the first lock,
// consider restructuring the code to release the database lock before working on individual tables if feasible.
// This suggestion points towards a conceptual modification since the exact fix would need a detailed understanding of the overall locking strategy and application structure.
// Potential approach:
for (String dbName : result.authorizedDbs) {
Database db = metadataMgr.getDb(catalogName, dbName);
if (db == null) {
continue;
}
List<String> tableNames = metadataMgr.listTableNames(catalogName, dbName);
// Release the first lock before acquiring more specific table locks
// Assuming some mechanism or rearrangement enables us to do so safely
for (String tableName : tableNames) {
if (request.isSetTable_name() && !tableName.equals(request.getTable_name())) {
continue;
}
Locker tableLocker = new Locker();
try {
BasicTable table = metadataMgr.getBasicTable(catalogName, dbName, tableName);
if (table == null) {
continue;
}
tableLocker.lockTablesWithIntensiveDbLock(db, Lists.newArrayList(((OlapTable) table).getId()), LockType.READ);
// process table...
} catch (Exception e) {
LOG.warn(e.getMessage());
} finally {
tableLocker.unLockTablesWithIntensiveDbLock(db, Lists.newArrayList(((OlapTable) table).getId()), LockType.READ);
}
}
}
// Note: This does not represent a complete solution but highlights the importance of addressing potential deadlock scenarios by carefully managing lock acquisition and release sequences.
|
[FE Incremental Coverage Report]✅ pass : 44 / 48 (91.67%) file detail
|
nshangyiming
approved these changes
May 9, 2024
[BE Incremental Coverage Report]✅ pass : 2 / 2 (100.00%) file detail
|
trueeyu
reviewed
May 9, 2024
trueeyu
reviewed
May 9, 2024
fe/fe-core/src/main/java/com/starrocks/service/InformationSchemaDataSource.java
Show resolved
Hide resolved
trueeyu
approved these changes
May 9, 2024
|
@Mergifyio backport branch-3.3 |
|
@Mergifyio backport branch-3.2 |
|
@Mergifyio backport branch-3.1 |
|
@Mergifyio backport branch-3.0 |
|
@Mergifyio backport branch-2.5 |
✅ Backports have been created
|
✅ Backports have been created
|
✅ Backports have been created
|
42 tasks
42 tasks
42 tasks
node
pushed a commit
to vivo/starrocks
that referenced
this pull request
May 17, 2024
…hema.tables (StarRocks#45351) Signed-off-by: HangyuanLiu <460660596@qq.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I'm doing:
What I'm doing:
Fixes #issue
What type of PR is this:
Does this PR entail a change in behavior?
If yes, please specify the type of change:
Checklist:
Bugfix cherry-pick branch check: