-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature] Support replacing UDF in-place with CREATE OR REPLACE FUNCTION
#46122
[Feature] Support replacing UDF in-place with CREATE OR REPLACE FUNCTION
#46122
Conversation
CREATE [OR REPLACE] FUNCTION
CREATE OR REPLACE FUNCTION
Signed-off-by: Jonathan Du <jdu@atlassian.com>
fdf0059
to
c1872e9
Compare
This PR doesn't include documentation change yet. I'll push another for that once we've settled on the proposed design. |
Signed-off-by: Jonathan Du <jdu@atlassian.com>
Signed-off-by: Jonathan Du <jdu@atlassian.com>
c1872e9
to
53a027c
Compare
Signed-off-by: Jonathan Du <jdu@atlassian.com>
7354cac
to
0e28e13
Compare
Signed-off-by: Jonathan Du <jdu@atlassian.com>
Sorry, folks. A Sonarcloud check appeared after your approval with a duplicate code warning. |
Looks like Sonarcloud is picking up code duplication in more than just my changes :( |
Signed-off-by: Jonathan Du <jdu@atlassian.com>
Signed-off-by: Jonathan Du <jdu@atlassian.com>
Quality Gate passedIssues Measures |
The long lead time between pushing a change and seeing check results has made this difficult. @packy92 @kangkaisen I'm hoping this is the last time I bug you for a review 🙏 |
[FE Incremental Coverage Report]✅ pass : 30 / 34 (88.24%) file detail
|
[BE Incremental Coverage Report]✅ pass : 0 / 0 (0%) |
Why I'm doing:
As of current, replacing a UDF is a two-step operation: DROP FUNCTION, then CREATE FUNCTION. This method involves potential downtime between the two commands for the function that is being replaced.
What I'm doing:
Fixes #46253
This change supports the following
The overall syntax for the enhanced CREATE FUNCTION command will look like this:
What type of PR is this:
Does this PR entail a change in behavior?
If yes, please specify the type of change:
Checklist:
Bugfix cherry-pick branch check: