Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Support replacing UDF in-place with CREATE OR REPLACE FUNCTION #46122

Merged
merged 8 commits into from
Jun 3, 2024

Conversation

digitalpoetry
Copy link
Contributor

@digitalpoetry digitalpoetry commented May 23, 2024

Why I'm doing:

As of current, replacing a UDF is a two-step operation: DROP FUNCTION, then CREATE FUNCTION. This method involves potential downtime between the two commands for the function that is being replaced.

What I'm doing:

Fixes #46253

This change supports the following

CREATE OR REPLACE FUNCTION function_name RETURNS return_type;

The overall syntax for the enhanced CREATE FUNCTION command will look like this:

CREATE [OR REPLACE] [GLOBAL] [AGGREGATE | TABLE] FUNCTION function_name
(arg_type [, ...])
RETURNS return_type
PROPERTIES ("key" = "value" [, ...]);

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.3
    • 3.2
    • 3.1
    • 3.0
    • 2.5

@digitalpoetry digitalpoetry requested review from a team as code owners May 23, 2024 06:57
@CLAassistant
Copy link

CLAassistant commented May 23, 2024

CLA assistant check
All committers have signed the CLA.

@digitalpoetry digitalpoetry changed the title Support replacing UDF in-place with CREATE [OR REPLACE] FUNCTION [Feature] Support replacing UDF in-place with CREATE OR REPLACE FUNCTION May 23, 2024
Signed-off-by: Jonathan Du <jdu@atlassian.com>
@digitalpoetry
Copy link
Contributor Author

This PR doesn't include documentation change yet. I'll push another for that once we've settled on the proposed design.

packy92
packy92 previously approved these changes May 24, 2024
Signed-off-by: Jonathan Du <jdu@atlassian.com>
Signed-off-by: Jonathan Du <jdu@atlassian.com>
Signed-off-by: Jonathan Du <jdu@atlassian.com>
kangkaisen
kangkaisen previously approved these changes May 29, 2024
packy92
packy92 previously approved these changes May 29, 2024
Signed-off-by: Jonathan Du <jdu@atlassian.com>
@digitalpoetry digitalpoetry dismissed stale reviews from packy92 and kangkaisen via 3e40dca May 29, 2024 05:12
@digitalpoetry
Copy link
Contributor Author

Sorry, folks. A Sonarcloud check appeared after your approval with a duplicate code warning.

@digitalpoetry
Copy link
Contributor Author

Looks like Sonarcloud is picking up code duplication in more than just my changes :(

kangkaisen
kangkaisen previously approved these changes May 29, 2024
Signed-off-by: Jonathan Du <jdu@atlassian.com>
Signed-off-by: Jonathan Du <jdu@atlassian.com>
Copy link

sonarcloud bot commented May 31, 2024

@digitalpoetry
Copy link
Contributor Author

The long lead time between pushing a change and seeing check results has made this difficult. @packy92 @kangkaisen I'm hoping this is the last time I bug you for a review 🙏

@kangkaisen kangkaisen enabled auto-merge (squash) June 3, 2024 01:51
Copy link

github-actions bot commented Jun 3, 2024

[FE Incremental Coverage Report]

pass : 30 / 34 (88.24%)

file detail

path covered_line new_line coverage not_covered_line_detail
🔵 com/starrocks/qe/DDLStmtExecutor.java 1 4 25.00% [241, 242, 243]
🔵 com/starrocks/catalog/Database.java 9 10 90.00% [669]
🔵 com/starrocks/sql/ast/CreateFunctionStmt.java 3 3 100.00% []
🔵 com/starrocks/catalog/GlobalFunctionMgr.java 17 17 100.00% []

Copy link

github-actions bot commented Jun 3, 2024

[BE Incremental Coverage Report]

pass : 0 / 0 (0%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support replacing UDF in-place with CREATE OR REPLACE FUNCTION
7 participants