Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Support replacing UDF in-place with CREATE OR REPLACE FUNCTION #1

Closed
wants to merge 8 commits into from

Conversation

digitalpoetry
Copy link
Owner

Why I'm doing:

As of current, replacing a UDF is a two-step operation: DROP FUNCTION, then CREATE FUNCTION. This method involves potential downtime between the two commands for the function that is being replaced.

What I'm doing:

Fixes StarRocks#46253

This change supports the following

CREATE OR REPLACE FUNCTION function_name RETURNS return_type;

The overall syntax for the enhanced CREATE FUNCTION command will look like this:

CREATE [OR REPLACE] [GLOBAL] [AGGREGATE | TABLE] FUNCTION function_name
(arg_type [, ...])
RETURNS return_type
PROPERTIES ("key" = "value" [, ...]);

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.3
    • 3.2
    • 3.1
    • 3.0
    • 2.5

Signed-off-by: Jonathan Du <jdu@atlassian.com>
Signed-off-by: Jonathan Du <jdu@atlassian.com>
Signed-off-by: Jonathan Du <jdu@atlassian.com>
Signed-off-by: Jonathan Du <jdu@atlassian.com>
Signed-off-by: Jonathan Du <jdu@atlassian.com>
Signed-off-by: Jonathan Du <jdu@atlassian.com>
Signed-off-by: Jonathan Du <jdu@atlassian.com>
@digitalpoetry
Copy link
Owner Author

Merged in StarRocks#46122

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant