Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BugFix] Allow skip authorization and reset root password #7361

Merged

Conversation

padmejin
Copy link
Contributor

What type of PR is this:

  • bug
  • feature
  • enhancement
  • refactor
  • others

Which issues of this PR fixes :

Fixes #7359

Problem Summary(Required) :

There must be other bugs somewhere once we set enable_auth_check to false, but this time I am only trying to make sure root password can be changed. The rest scenerios are off my consideration for now.

@wanpengfei-git
Copy link
Collaborator

[FE PR Coverage check]

😞 fail : 3 / 4 (75.00%)

file detail

path covered line new line coverage
🔵 com/starrocks/mysql/privilege/Auth.java 1 2 50.00%
🔵 com/starrocks/mysql/MysqlProto.java 2 2 100.00%

@chaoyli chaoyli changed the title [BugFix] allow skip authorization and reset root password [BugFix] Allow skip authorization and reset root password Jun 16, 2022
@imay imay merged commit c25cf97 into StarRocks:main Jun 17, 2022
@padmejin padmejin deleted the dev/skip_auth_check_and_change_password branch July 12, 2022 11:08
@padmejin
Copy link
Contributor Author

@Mergifyio backport branch-2.2 branch-2.1 branch-2.0 Gracias~

mergify bot pushed a commit that referenced this pull request Jul 15, 2022
(cherry picked from commit c25cf97)

# Conflicts:
#	fe/fe-core/src/main/java/com/starrocks/mysql/privilege/Auth.java
mergify bot pushed a commit that referenced this pull request Jul 15, 2022
(cherry picked from commit c25cf97)

# Conflicts:
#	fe/fe-core/src/main/java/com/starrocks/mysql/privilege/Auth.java
mergify bot pushed a commit that referenced this pull request Jul 15, 2022
(cherry picked from commit c25cf97)

# Conflicts:
#	fe/fe-core/src/main/java/com/starrocks/mysql/privilege/Auth.java
@mergify
Copy link
Contributor

mergify bot commented Jul 15, 2022

backport branch-2.2 branch-2.1 branch-2.0 Gracias~

❌ No backport have been created

@padmejin
Copy link
Contributor Author

padmejin commented Sep 2, 2022

@Mergifyio backport branch-2.3

@mergify
Copy link
Contributor

mergify bot commented Sep 2, 2022

backport branch-2.3

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Sep 2, 2022
wanpengfei-git pushed a commit that referenced this pull request Sep 2, 2022
padmejin added a commit to padmejin/starrocks that referenced this pull request Sep 16, 2022
This bug was originally fixed by StarRocks#7361. But was reintroduced in StarRocks#11099.
Astralidea pushed a commit that referenced this pull request Sep 17, 2022
This bug was originally fixed by #7361. But was reintroduced in #11099.
mergify bot pushed a commit that referenced this pull request Sep 17, 2022
This bug was originally fixed by #7361. But was reintroduced in #11099.

(cherry picked from commit 19fb2dc)
mergify bot pushed a commit that referenced this pull request Sep 17, 2022
This bug was originally fixed by #7361. But was reintroduced in #11099.

(cherry picked from commit 19fb2dc)
wanpengfei-git pushed a commit that referenced this pull request Sep 17, 2022
This bug was originally fixed by #7361. But was reintroduced in #11099.

(cherry picked from commit 19fb2dc)
wanpengfei-git pushed a commit that referenced this pull request Sep 19, 2022
This bug was originally fixed by #7361. But was reintroduced in #11099.

(cherry picked from commit 19fb2dc)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't skip authorization and reset root password
4 participants