Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Differentiates arrays and objects #37

Closed

Conversation

jamesplease
Copy link
Contributor

Start of a solution to #31.

This begins the process of differentiating between arrays and objects. The fix in this PR only compares empty ones, though. It'll likely take a different sort of refactor to handle all cases.

To test:

// On master, you get nothing.
jsonpatch.compare({a: {}}, {a: []});

// On this branch, you get a nice replace. Yippee

@warpech
Copy link
Collaborator

warpech commented Jun 3, 2016

Are you still using this? Could you please add a test for it?

@jamesplease
Copy link
Contributor Author

I'm not using it. Gonna close cause I won't have 🕰

@jamesplease jamesplease closed this Jun 3, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants