Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Companion Anger Dialogue Bugs #804

Closed
Constellation-VASCO opened this issue Jan 5, 2024 · 1 comment
Closed

Companion Anger Dialogue Bugs #804

Constellation-VASCO opened this issue Jan 5, 2024 · 1 comment
Labels
Fix Ready A fix for this issue is ready for merging and testing Platform: PC (Steam) This issue is being reported from the PC release of Starfield on Steam Type: Missions & Dialogue Relates to missions (quests), NPC dialogue or player dialogue options

Comments

@Constellation-VASCO
Copy link
Collaborator

The following bugs are present with the "angry" conversations with companions:

  • After the companion explains what they player did (generic, murder, or jealousy), the player's follow-up question can only ever be about the generic reason, despite dialogue for the other reasons being present in the files.
  • If you successfully persuade Andreja to not leave you, she will still incorrectly say that she will leave you.

Details

The player dialogue choices with FormIDs 002C5A0C, 0014317F, 00143173, and 0023EE2D have conditions to check the COM_AngerReason AV, and appear if they match. However, this AV is checked against the player, not the companion, so they never correctly appear. To fix it, run the condition on the Target instead of the Subject.

Likewise, the dialogue choices for the generic anger reasons have no conditions at all, and can show up in addition to the correct one if left unchanged. The FormIDs for those dialogue choices are: 002C5A04, 0014320F, and 0023EDE6.

For Andreja, a condition can be added to not play the "I am leaving" lines when COM_AngerLevel <> 0 to fix that issue. The FormIDs for those dialogue lines are: 001E9F5A and 001E9F5B.

I have uploaded a fix for these issues here: https://1drv.ms/u/s!AhuMaF-FsKU-lBkEJyKWGpqyVm_t?e=GSawFA

Game Version

1.8.88.0

Language

English (EN)

New Game

Yes

Reproduction Steps

Anger a companion for reasons of murder or jealousy, check what your follow-up question is after they explain why they are mad. For Andreja, successfully convince her to stay.

@Constellation-VASCO Constellation-VASCO added Platform: PC (Steam) This issue is being reported from the PC release of Starfield on Steam Type: Missions & Dialogue Relates to missions (quests), NPC dialogue or player dialogue options labels Jan 5, 2024
@Constellation-VASCO
Copy link
Collaborator Author

Correction to one of my sentences: For Andreja, a condition can be added to only play the "I am leaving" lines when COM_AngerLevel <> 0 to fix that issue.

@Pickysaurus Pickysaurus added the Fix Ready A fix for this issue is ready for merging and testing label Feb 13, 2024
Pickysaurus added a commit that referenced this issue Mar 30, 2024
Fixes #826
Fixes #649
Fixes #804
Fixes #772
Fixes #771
Fixes #631
Fixes #782
Fixes #818
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Fix Ready A fix for this issue is ready for merging and testing Platform: PC (Steam) This issue is being reported from the PC release of Starfield on Steam Type: Missions & Dialogue Relates to missions (quests), NPC dialogue or player dialogue options
Projects
Status: Closed
Development

No branches or pull requests

2 participants