-
Notifications
You must be signed in to change notification settings - Fork 22
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Save Flux_scalars, the average value of each model spectrum, required…
… for absolute flux of models and accurate solid angles. Note that this is backwards-INCOMPATIBLE. We have to pass an extra positional argument to many of the classes and methods that are not expecting one. So trying to use this code with previous versions will fail. This change is not desirable but the old code was misleading in the solid angle support, so it can be considered a bug fix.
- Loading branch information
Showing
1 changed file
with
26 additions
and
34 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7b2afc7
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This sounds like a good idea! It does a much more intuitive job of bookkeeping than the previous solutions (which should be considered buggy, as you note). As long as we keep everything to the development branch for now, I am more than OK with backwards-incompatible changes if they make the next release (v2.0?) that much more user-friendly. At that point we'll just need to do a thorough job updating (and perhaps simplifying) the documentation and tutorials.