Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make world does not install all documents #4

Closed
timj opened this issue Jul 26, 2013 · 5 comments
Closed

make world does not install all documents #4

timj opened this issue Jul 26, 2013 · 5 comments
Assignees
Labels

Comments

@timj
Copy link
Member

timj commented Jul 26, 2013

Even though the documents in docs/ work with bootstrap, configure and make, they are not part of make world. For example sgp38.tex is not built. Looking at the Makefile there are only entries for:

    $(MANIFESTS)/sc2 \
    $(MANIFESTS)/sc3 \
    $(MANIFESTS)/sc4 \
    $(MANIFESTS)/sc5 \
    $(MANIFESTS)/sc6 \
    $(MANIFESTS)/sc7 \
    $(MANIFESTS)/sc9 \
    $(MANIFESTS)/sc12 \
    $(MANIFESTS)/sc14 \
    $(MANIFESTS)/sc15 \
    $(MANIFESTS)/sc17 \
    $(MANIFESTS)/sc21 \
    $(MANIFESTS)/sg8 \
    $(MANIFESTS)/sg9

but Makefile.dependencies lists all the documents properly. I think that the new documents were never added to Makefile.in. I see that @pwdraper added the cookbooks and sg8 and sg9 in 2f49bb3 but there was no correponding followup commit to 963e493 which was the one that added all the other documents to the dependencies file in 2008.

I'm amazed I only just noticed. It came up because I needed an online link to SGP/38.

@ghost ghost assigned timj Jul 26, 2013
@timj timj closed this as completed in 38caef8 Jul 26, 2013
@pwdraper
Copy link
Member

I expect the reason I didn't include all the documents is that the build state of them was unknown at
the time @MalcolmCurrie was still working on them. At least that's what I remember.

@timj
Copy link
Member Author

timj commented Jul 26, 2013

Turns out that SUN/93 is actually written in TeX and not LaTeX so the build doesn't complete. Given that none of the documentation build targets understand TeX files and given the SUN/93 is a document explaining how TeX should be used, it's probably fine to remove it from the build. A compromise may be to adjust the make target to simply install sun93.tex in the documentation tree without attempting to build it.

@timj
Copy link
Member Author

timj commented Jul 26, 2013

@MalcolmCurrie sorted this out with commit e22dc98 reasoning that a document on using TeX is not useful when the standard is to use LaTeX.

timj added a commit that referenced this issue Jul 26, 2013
Commit e22dc98 moved SUN/93 to obsolete
but it did not remove it from the build.

This is continuing fallout from Issue #4
@MalcolmCurrie
Copy link
Contributor

I expect the reason I didn't include all the documents is that the build state of them was unknown at
the time @MalcolmCurrie was still working on them. At least that's what I remember.

Looking back I had added many documents then in 2008 January there was a
discussion ("document building") on adding these to the build instigated
by @timj with most responses from @pwdraper with contributions from
@MalcolmCurrie and @nxg. There was some build issue to do with

kpathsea. Looks like the ball was dropped.

Scanned by iCritical.

@timj
Copy link
Member Author

timj commented Jul 27, 2013

Well, I hope everything is sorted out now. There was only that one problem and we are ignoring the XML documents.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants