Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Link to tor address on LAN setup page (#1277) #1466

Merged
merged 2 commits into from Jun 1, 2022
Merged

Link to tor address on LAN setup page (#1277) #1466

merged 2 commits into from Jun 1, 2022

Conversation

BBlackwo
Copy link
Contributor

@BBlackwo BBlackwo commented May 28, 2022 •
edited

Plus a little bit of refactoring of the component.

Closes #1277

Screenshot

Screenshot from 2022-05-28 13-59-12

@kn0wmad kn0wmad requested a review from elvece May 28, 2022 21:00
@ProofOfKeags ProofOfKeags added Enhancement New feature or request UI Issues pertaining to any of the embassy-served web applications P2 - Desirable high prioity, nice-to-haves labels May 31, 2022
@ProofOfKeags ProofOfKeags added this to Code Review in EmbassyOS 0.3.1 via automation May 31, 2022
@ProofOfKeags ProofOfKeags added this to the 0.3.1 milestone May 31, 2022
elvece
elvece approved these changes Jun 1, 2022
View reviewed changes
Copy link
Member

@elvece elvece left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice! appreciate the small refactor as well - this was a recent change and is the pattern that should be adopted. thanks!

@elvece elvece merged commit 34068ef into Start9Labs:master Jun 1, 2022
EmbassyOS 0.3.1 automation moved this from Code Review to Done Jun 1, 2022
@BBlackwo BBlackwo deleted the feature/link-tor-address-on-lan-setup-page branch June 1, 2022 23:37
@BBlackwo
Copy link
Contributor Author

BBlackwo commented Jun 1, 2022

nice! appreciate the small refactor as well - this was a recent change and is the pattern that should be adopted. thanks!

Ahh cool. Glad I unintentionally followed the right pattern 😀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elvece elvece elvece approved these changes

Assignees

@BBlackwo BBlackwo

@elvece elvece

Labels
Enhancement New feature or request P2 - Desirable high prioity, nice-to-haves UI Issues pertaining to any of the embassy-served web applications
Projects
No open projects
EmbassyOS 0.3.1
Done
Milestone
0.3.1
Development

Successfully merging this pull request may close these issues.

[feat]: Display Tor address on LAN setup page when accessed over LAN
3 participants
@BBlackwo @elvece @ProofOfKeags