Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable Control Groups for Docker containers #1468

Merged
merged 1 commit into from
Jun 6, 2022
Merged

Enable Control Groups for Docker containers #1468

merged 1 commit into from
Jun 6, 2022

Conversation

k0gen
Copy link
Member

@k0gen k0gen commented May 28, 2022

Enabling Control Groups give Docker containers the ability to track and expose missing memory metrics.
Here is an example of desirable output of docker stats command from your EmbassyOS:
Screenshot 2022-05-28 at 18 30 27

@k0gen
Enable Control Groups for Docker containers
3853dc2 
Enabling Control Groups give Docker containers the ability to track and expose missing memory metrics. Try `docker stats`
@kn0wmad kn0wmad requested a review from dr-bonez May 29, 2022 22:54
@ProofOfKeags ProofOfKeags added Needs Scoping Requirements are not fully defined Needs Triage Needs to be assigned a priority Enhancement New feature or request labels May 31, 2022
@dr-bonez dr-bonez added P2 - Desirable high prioity, nice-to-haves and removed Needs Triage Needs to be assigned a priority labels Jun 1, 2022
kn0wmad
kn0wmad approved these changes Jun 6, 2022
View reviewed changes
Copy link
Contributor

@kn0wmad kn0wmad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice addition, thanks as always brother!!

@kn0wmad kn0wmad merged commit 34729c4 into Start9Labs:master Jun 6, 2022
kn0wmad added a commit that referenced this pull request Jun 6, 2022
@kn0wmad
Revert "Enable Control Groups for Docker containers (#1468)"
e414940 
This reverts commit 34729c4.
@k0gen k0gen mentioned this pull request Jul 8, 2022
Merged
@k0gen k0gen deleted the patch-3 branch July 12, 2022 06:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kn0wmad kn0wmad kn0wmad approved these changes

@dr-bonez dr-bonez Awaiting requested review from dr-bonez

Assignees

@dr-bonez dr-bonez

Labels
Enhancement New feature or request Needs Scoping Requirements are not fully defined P2 - Desirable high prioity, nice-to-haves
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@k0gen @kn0wmad @dr-bonez @ProofOfKeags