Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes serialization of regex pattern + description #1509

Merged
merged 1 commit into from Jun 7, 2022

Conversation

ProofOfKeags
Copy link
Contributor

@ProofOfKeags ProofOfKeags commented Jun 7, 2022

This fixes an issue introduced by #1498. We deflattened the structure due to issues with how the flattening algorithm caused the deserialization process to believe a pattern/description that was wrong to instead be missing. However, when we handrolled the Deserialize Implementation we also naively removed the flatten as well. This caused the Serialize implementation (which was still macro derived) to deflatten. This caused the front end to interpret what it expected (but did not check CC @elvece) to be a regex but instead was an object that had a regex and string row. Therefore U.test is not a function is a result of indexing into the object to find what it thought to be Regex.test but instead found nothing...because it was an object. Reintroducing the flatten directive will undo this process without altering how the Deserialize behaves.

@ProofOfKeags ProofOfKeags added Bug Something isn't working startd Issues pertaining to startd itself P0 - Blocks Dev This issue is mission critical to address imminently labels Jun 7, 2022
@ProofOfKeags ProofOfKeags added this to Code Review in EmbassyOS 0.3.1 via automation Jun 7, 2022
@ProofOfKeags ProofOfKeags added this to the 0.3.1 milestone Jun 7, 2022
@ProofOfKeags ProofOfKeags merged commit 901ea62 into master Jun 7, 2022
EmbassyOS 0.3.1 automation moved this from Code Review to Done Jun 7, 2022
@ProofOfKeags ProofOfKeags deleted the bugfix/nested-regex-patterns branch June 7, 2022 23:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working P0 - Blocks Dev This issue is mission critical to address imminently startd Issues pertaining to startd itself
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

2 participants