Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Jekyll 4.0 #223

Merged
merged 2 commits into from Jun 18, 2020
Merged

Conversation

thejimnicholson
Copy link
Contributor

I've modified the Gemfile and .gemspec to allow this to work with Jekyll 4.0. I've tested it as much as I can with a new site I'm building. On a fresh jekyll site, I had to modify _config.yml and the Gemfile to include jekyll-paginator to avoid some deprecation warnings, but other than that, it seems to work.

@dchaley
Copy link

dchaley commented Jan 27, 2020

Hello! I found this since I was trying to work with a new jekyll setup using version 4.

I can confirm that this PR makes it work, although yes I needed to include jekyll-paginate (not paginator) to work around the deprecation warning. It's still telling me this on jekyll serve :

Pagination: Pagination is enabled, but I couldn't find an index.html page to use as the pagination template. Skipping pagination.

@goplusgo
Copy link

Hope this PR gets merged ASAP.

@davidtmiller davidtmiller merged commit 9bc8a51 into StartBootstrap:master Jun 18, 2020
@davidtmiller
Copy link
Member

Thanks for going through the process of testing this out! I've tested things out on my end and I'm not getting any errors so I think we are good to go with this change. Thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants