Fix navbar toggle #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CSS rules for the toggle had been useless since .navbar-toggle is not inside .navbar-brand in the html code. This resulted in a too high navbar in mobile view. Furthermore the toggle was not in the middle.
|
What's wrong about it? |
|
I think this one got fixed in another pull request |
|
No, not completely. |
|
Oh I understand now. I am going to merge it for this version of the theme, but the whole toggle element will be updated soon, but for legacy versions or people using this version it will be fixable. Thanks for the clarification! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CSS rules for the toggle had been useless since .navbar-toggle is not inside .navbar-brand in the html code.
This resulted in a too high navbar in mobile view.
Furthermore the toggle was not in the middle.