-
-
Notifications
You must be signed in to change notification settings - Fork 642
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
writable area decreases when window 1199px --> 1200px (workaround provided) #48
Comments
Hmm I'm sorry but I don't get what you mean by "writeable area". Can you please post screenshot/s to reproduce it? I'm asking because we should understand the issue in order to fix it 😉 |
The area that the text is rendered into.
Sure, no problem. Here: Hope that helps :-) P.S.: Using your theme as the basis for my new website (#46 (comment)). Thanks a lot :-) |
Oh I see what you mean.. Our CSS champion is @joariasl by the way. @joariasl any ideas why this is happening? 😓 @altsheets Can you please open a pull request with your suggestion in order to test it and merge it with the repo? 😉 P.S.: Your website looks great! 😉 |
This week I think that I have more free time. It is easy to fix. I will take a time to implement other improvements. |
@altsheets that's why we call him the CSS champion of the repo! 😜 👏 |
Nice. Happy to hear.
... and looking forward to those!
Not sure that is necessary. Ah ... another good idea, to operationalize this, and to keep it clean.
put all your "personal-jekyll-theme" CSS changes into personal.css. And suggest to users / forkers ... to put their additional styles into user.css ! Then you can import the unchanged(!) grayscale.css and timeline.css from their original sources, and all your "personal-jekyll-theme" specific CSS will just override those. The advantage: If there are newer, updated commits of the original grayscale.css / timeline.css it will be really easy to merge them into PJT. In my case, I had just added an "altsheets.css" into line 31, and put all my style changes into that file. This way I could keep your .CSS unchanged. And CSS that is loaded later, will override CSS that is loaded earlier (I looked that up * g * ).
Happy to help. Cooperation ... that is best aspect of the internets.
Thanks a lot. Yours, too * lol * |
Fixed here commit/004cf1f53e341b68ab9d80f11b290f2249ce34fe |
ah, that makes sense. I had actually already suspected s.th. like that, Cool. Thanks a lot |
and what about the idea to leave the original
untouched, and just override it with a (later-loaded)
in which all the local changes are kept together? See the 2nd part of #48 (comment) For now, it might be a bit of a hassle, but a good compare-tool will make it easy. Long-term it is definitely of advantage. Thanks for considering it. |
The original grayscale style contains any bugs not corrected. Another person saw the same errors: At the end we should leave the modified copy, could not bear to leave these errors. 😜 |
for some reason, the writable area
decreases(!) from 970px width to 780px width
when the window size increases from 1199px to 1200px.
Not sure why (I am not an experienced CSS designer),
but this workaround fixed it for me:
HTH
:-)
The text was updated successfully, but these errors were encountered: