Skip to content

Commit

Permalink
fix iam patch logic and update image in config (kubeflow#1582)
Browse files Browse the repository at this point in the history
  • Loading branch information
kunmingg authored and k8s-ci-robot committed Sep 20, 2018
1 parent 51f1f2f commit 12603d5
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 3 deletions.
3 changes: 3 additions & 0 deletions bootstrap/cmd/bootstrap/app/gcpUtils.go
Original file line number Diff line number Diff line change
Expand Up @@ -131,6 +131,9 @@ func GetUpdatedPolicy(currentPolicy *cloudresourcemanager.Policy, iamConf *IamCo
actualMember = val
}
for _, role := range binding.Roles {
if _, ok := policyMap[role]; !ok {
policyMap[role] = make(map[string]bool)
}
if req.Action == "add" {
policyMap[role][actualMember] = true
} else {
Expand Down
2 changes: 1 addition & 1 deletion bootstrap/cmd/bootstrap/app/ksServer.go
Original file line number Diff line number Diff line change
Expand Up @@ -355,7 +355,7 @@ func (s *ksServer) getRegistryUri(registry *RegistryConfig) (string, error) {
if err != nil {
os.Mkdir(registryPath, os.ModePerm)
}
fileUrl := path.Join(registry.Repo, "archive", registry.Version + ".tar.gz")
fileUrl := registry.Repo + "/archive/" + registry.Version + ".tar.gz"

err = runCmd(fmt.Sprintf("curl -L -o %v %v", versionPath + ".tar.gz", fileUrl))
if err != nil {
Expand Down
4 changes: 2 additions & 2 deletions components/gcp-click-to-deploy/manifest/kf_app.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -96,14 +96,14 @@ spec:
spec:
containers:
- name: web-app
image: gcr.io/kubeflow-images-public/test-app:0914
image: gcr.io/kubeflow-images-public/test-app:091802
ports:
- containerPort: 3000
volumeMounts:
- name: config-volume
mountPath: /app/src/user_config
- name: controller-backend
image: gcr.io/kubeflow-images-public/bootstrapper:v20180913-0ec42ca3-dirty-b41bd1
image: gcr.io/kubeflow-images-public/bootstrapper:v20180919-8a2e8c7-dirty-9c6b53
workingDir: /opt/bootstrap
command: [ "/opt/kubeflow/bootstrapper"]
args: [
Expand Down

0 comments on commit 12603d5

Please sign in to comment.