fix iam patch logic and update image in config #1582
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abhi-g
reviewed
Sep 20, 2018
| @@ -355,7 +355,7 @@ func (s *ksServer) getRegistryUri(registry *RegistryConfig) (string, error) { | |||
| if err != nil { | |||
| os.Mkdir(registryPath, os.ModePerm) | |||
| } | |||
| fileUrl := path.Join(registry.Repo, "archive", registry.Version + ".tar.gz") | |||
| fileUrl := registry.Repo + "/archive/" + registry.Version + ".tar.gz" | |||
There was a problem hiding this comment.
What was the issue with path.Join?
There was a problem hiding this comment.
There's a chance that path.Join will turn // to /, might generate invalid urls.
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: abhi-g The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
swiftdiaries
pushed a commit
to swiftdiaries/kubeflow
that referenced
this pull request
Sep 21, 2018
swiftdiaries
added a commit
to swiftdiaries/kubeflow
that referenced
this pull request
Sep 21, 2018
This reverts commit e686f78.
saffaalvi
pushed a commit
to StatCan/kubeflow
that referenced
this pull request
Feb 11, 2021
surajkota
pushed a commit
to surajkota/kubeflow
that referenced
this pull request
Jun 13, 2022
…tion used in KfDef (kubeflow#1582) * add IBM stack components * add IBM stack components * revert seldon test expected data * switch to base_v3 for istio-stack
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is