Honour custom_footer_text #13
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is the intended difference between |
|
Yes, #14 is more general and allows one to insert text at more than one location. |
OK, closing this then |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Honour and implement setter for attribute custom_footer_text. The implementation (argument is a list where each element is a custom footer text) follows that of add_custom_notes.
The placement of the footer is the same as in the Stargazer R package (at the top of the footer). However, a variable to change that placement - or several lists and a corresponding (optional) parameter for the add_custom_footer_text method - may be useful.
The variable and methods could be renamed to "custom_footer_texts" to remain consistent with the custom_notes attribute.