Documented function of delete_line is more like clr_eol
#68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You have the correct fix, sorry for the delay. However, terminfo currently uses the short names so the correct capability would be |
We use the shortnames (for now).
|
Given that I completely forgot about this and left you hanging for weeks, I decided to just make the change for you and merge. |
|
Thanks!
…On Wed, Jan 25, 2017, 5:15 PM Steven Allen ***@***.***> wrote:
Given that I completely forgot about this and left you hanging for weeks,
I decided to just make the change for you and merge.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#68 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAVI80NsoI23-WdBhLy2Nwgkypa0PeSQks5rV_OhgaJpZM4LUa34>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #67.
In terminfo as far as I can make out,
dlmeans delete the current line and move up from below, whereas yourterm.delete_lineis described as deleting to the end of the line.Possibly this should be fixed in the other direction by adding a new function, and updating the
delete_linebehavior. But I think the current docstring is accurate on Windows.