Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

catch missing delimiters when building connection strings #1084

Merged
merged 4 commits into from
Dec 22, 2022

Conversation

TimHess
Copy link
Member

@TimHess TimHess commented Dec 22, 2022

Description

Handle cases where a user-provided connection string does not end with the delimiter and other settings are appended

Addresses #1076 in release/3.2 - A similar fix needs to happen for 4.0 but for that release we can choose to only prepend the delimiter instead of appending

Quality checklist

  • Your code complies with our Coding Style.
  • You've updated unit and/or integration tests for your change, where applicable.
  • You've updated documentation for your change, where applicable.
    If your change affects other repositories, such as Documentation, Samples and/or MainSite, add linked PRs here.
  • There's an open issue for the PR that you are making. If you'd like to propose a new feature or change, please open an issue to discuss the change or find an existing issue.
  • You've added required license files and/or file headers (explaining where the code came from with proper attribution), where code is copied from StackOverflow, a blog, or OSS.

@TimHess TimHess added Component/Connectors Issues related to Steeltoe connectors ReleaseLine/3.x Identified as a feature/fix for the 3.x release line labels Dec 22, 2022
@TimHess TimHess added this to the 3.2.2 milestone Dec 22, 2022
@TimHess TimHess self-assigned this Dec 22, 2022
@TimHess TimHess marked this pull request as ready for review December 22, 2022 16:57
@TimHess
Copy link
Member Author

TimHess commented Dec 22, 2022

/azp run Steeltoe.All

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@sonarcloud
Copy link

sonarcloud bot commented Dec 22, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

Copy link
Contributor

@hananiel hananiel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM;

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@TimHess TimHess merged commit 984ea35 into release/3.2 Dec 22, 2022
@TimHess TimHess deleted the connector_trailingDelimiter branch December 22, 2022 20:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component/Connectors Issues related to Steeltoe connectors ReleaseLine/3.x Identified as a feature/fix for the 3.x release line
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants