Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backport CNB override of ConnectionString in Connectors #1104

Merged
merged 1 commit into from
Feb 14, 2023
Merged

Backport CNB override of ConnectionString in Connectors #1104

merged 1 commit into from
Feb 14, 2023

Conversation

TimHess
Copy link
Member

@TimHess TimHess commented Feb 9, 2023

Description

backport of #1103 to 3.2

Quality checklist

  • Your code complies with our Coding Style.
  • You've updated unit and/or integration tests for your change, where applicable.
  • You've updated documentation for your change, where applicable.
    If your change affects other repositories, such as Documentation, Samples and/or MainSite, add linked PRs here.
  • There's an open issue for the PR that you are making. If you'd like to propose a new feature or change, please open an issue to discuss the change or find an existing issue.
  • You've added required license files and/or file headers (explaining where the code came from with proper attribution), where code is copied from StackOverflow, a blog, or OSS.

@TimHess @bart-vmware
CNB override ConnectionString in Connectors
8f6ab5a 
* add some tests for using CNB from Connectors
* Ignore ConnectionString from settings if cloud native bindings are found (just like with VCAP_SERVICES)

Co-authored-by: Bart Koelman <104792814+bart-vmware@users.noreply.github.com>
@TimHess TimHess added Component/Connectors Issues related to Steeltoe connectors ReleaseLine/3.x Identified as a feature/fix for the 3.x release line labels Feb 9, 2023
@TimHess TimHess added this to the 3.2.3 milestone Feb 9, 2023
@TimHess TimHess self-assigned this Feb 9, 2023
@TimHess
Copy link
Member Author

TimHess commented Feb 13, 2023

/azp run Steeltoe.All

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@sonarcloud
Copy link

sonarcloud bot commented Feb 13, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

100.0% 100.0% Coverage
0.0% 0.0% Duplication

bart-vmware
bart-vmware reviewed Feb 14, 2023
View reviewed changes
Copy link
Member

@bart-vmware bart-vmware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TimHess TimHess merged commit 34c1143 into release/3.2 Feb 14, 2023
@TimHess TimHess deleted the backport_1103 branch February 14, 2023 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bart-vmware bart-vmware bart-vmware approved these changes

@hananiel hananiel Awaiting requested review from hananiel

@dtillman dtillman Awaiting requested review from dtillman

Assignees

@TimHess TimHess

Labels
Component/Connectors Issues related to Steeltoe connectors ReleaseLine/3.x Identified as a feature/fix for the 3.x release line
Projects
None yet
Milestone
3.2.3
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@TimHess @bart-vmware