Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow return of empty string values through placeholder resolver (3.2) #1133

Merged
merged 1 commit into from
Jun 13, 2023

Conversation

TimHess
Copy link
Member

@TimHess TimHess commented Jun 12, 2023

Description

Patch to return the expected empty string instead of null when placeholder resolver is used

addresses #1132 in 3.2, will need to be applied to 4.0 as well.

Quality checklist

  • Your code complies with our Coding Style.
  • You've updated unit and/or integration tests for your change, where applicable.
  • You've updated documentation for your change, where applicable.
    If your change affects other repositories, such as Documentation, Samples and/or MainSite, add linked PRs here.
  • There's an open issue for the PR that you are making. If you'd like to propose a new feature or change, please open an issue to discuss the change or find an existing issue.
  • You've added required license files and/or file headers (explaining where the code came from with proper attribution), where code is copied from StackOverflow, a blog, or OSS.

@TimHess TimHess added Type/bug Something isn't working Component/Configuration Issues related to Configuration providers ReleaseLine/3.x Identified as a feature/fix for the 3.x release line labels Jun 12, 2023
@TimHess TimHess added this to the 3.2.4 milestone Jun 12, 2023
@TimHess TimHess self-assigned this Jun 12, 2023
@TimHess
Copy link
Member Author

TimHess commented Jun 12, 2023

/azp run Steeltoe.All

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@sonarcloud
Copy link

sonarcloud bot commented Jun 12, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@bart-vmware
Copy link
Member

LGTM

@TimHess TimHess requested a review from bart-vmware June 13, 2023 13:31
@TimHess TimHess merged commit 20744ac into release/3.2 Jun 13, 2023
17 of 19 checks passed
@TimHess TimHess deleted the placeholder_emptyvalue branch June 13, 2023 13:38
@TimHess TimHess changed the title Allow return of empty string values through placeholder resolver Allow return of empty string values through placeholder resolver (3.2) Jun 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component/Configuration Issues related to Configuration providers ReleaseLine/3.x Identified as a feature/fix for the 3.x release line Type/bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants