Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restrict Otel versions to those supported #1166

Merged
merged 1 commit into from
Aug 23, 2023
Merged

Conversation

hananiel
Copy link
Contributor

Description

We typically use minimum versions in our upstream dependencies, but consumers of Steeltoe may add a later version causing runtime errors. This will make it a compiler error if dependency limits are violated.

Quality checklist

  • Your code complies with our Coding Style.
  • You've updated unit and/or integration tests for your change, where applicable.
  • You've updated documentation for your change, where applicable.
    If your change affects other repositories, such as Documentation, Samples and/or MainSite, add linked PRs here.
  • There's an open issue for the PR that you are making. If you'd like to propose a new feature or change, please open an issue to discuss the change or find an existing issue.
  • You've added required license files and/or file headers (explaining where the code came from with proper attribution), where code is copied from StackOverflow, a blog, or OSS.

@hananiel hananiel added the Component/Management Issues related to Steeltoe Management (actuators) label Aug 22, 2023
@hananiel hananiel added this to the 3.2.4 milestone Aug 22, 2023
@hananiel hananiel requested a review from TimHess August 22, 2023 01:04
@hananiel hananiel self-assigned this Aug 22, 2023
@TimHess
Copy link
Member

TimHess commented Aug 22, 2023

/azp run Steeltoe.All

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

1 similar comment
@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@sonarcloud
Copy link

sonarcloud bot commented Aug 23, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@TimHess TimHess added the ReleaseLine/3.x Identified as a feature/fix for the 3.x release line label Aug 23, 2023
@TimHess TimHess merged commit f5bacf1 into release/3.2 Aug 23, 2023
18 of 20 checks passed
@TimHess TimHess deleted the Otel_versions branch August 23, 2023 19:49
@TimHess
Copy link
Member

TimHess commented Aug 23, 2023

This issue resolves #1125

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component/Management Issues related to Steeltoe Management (actuators) ReleaseLine/3.x Identified as a feature/fix for the 3.x release line
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants