Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix SpringBootEnvProvider throws unhandled exception #1170

Merged
merged 4 commits into from
Sep 12, 2023

Conversation

hananiel
Copy link
Contributor

Description

The placeholder resolver loads configuration multiple times by design. The SpringBootEnvProvider inherits eventually from StreamConfigurationProvider that does not allow multiple reloads of configuration.

Fixes #1169

Quality checklist

  • Your code complies with our Coding Style.
  • You've updated unit and/or integration tests for your change, where applicable.
  • You've updated documentation for your change, where applicable.
    If your change affects other repositories, such as Documentation, Samples and/or MainSite, add linked PRs here.
  • There's an open issue for the PR that you are making. If you'd like to propose a new feature or change, please open an issue to discuss the change or find an existing issue.
  • You've added required license files and/or file headers (explaining where the code came from with proper attribution), where code is copied from StackOverflow, a blog, or OSS.

@hananiel
Copy link
Contributor Author

hananiel commented Aug 31, 2023

/azp run Steeltoe.All

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@hananiel hananiel marked this pull request as ready for review September 12, 2023 00:17
@hananiel hananiel self-assigned this Sep 12, 2023
@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@TimHess TimHess added this to the 3.2.5 milestone Sep 12, 2023
@TimHess TimHess added Type/bug Something isn't working Component/Configuration Issues related to Configuration providers ReleaseLine/3.x Identified as a feature/fix for the 3.x release line labels Sep 12, 2023
@sonarcloud
Copy link

sonarcloud bot commented Sep 12, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@hananiel hananiel merged commit 7f43c84 into release/3.2 Sep 12, 2023
20 checks passed
@hananiel hananiel deleted the SpringBootEnv branch September 12, 2023 21:49
@TimHess TimHess mentioned this pull request Dec 8, 2023
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component/Configuration Issues related to Configuration providers ReleaseLine/3.x Identified as a feature/fix for the 3.x release line Type/bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants