#984 single file publish works with Service connectors

[thompson-tomo]

Description

This fix enables dotnet application's published as a single file to work which would previously fail due to an issue loading files

Fixes #984

Quality checklist

• Your code complies with our Coding Style.
• You've updated unit and/or integration tests for your change, where applicable.
• You've updated documentation for your change, where applicable.
  If your change affects other repositories, such as Documentation, Samples and/or MainSite, add linked PRs here.
• There's an open issue for the PR that you are making. If you'd like to propose a new feature or change, please open an issue to discuss the change or find an existing issue.
• You've added required license files and/or file headers (explaining where the code came from with proper attribution), where code is copied from StackOverflow, a blog, or OSS.

[thompson-tomo]

@dotnet-policy-service agree

[TimHess]

Hey @thompson-tomo,

Thanks for digging into this, I see what you're doing here and I see how it allows the application to continue when published as a single file, but I'm trying to understand if this should be the right behavior.

Swallowing the exception is fine if you're not really dependent on whatever Steeltoe feature is doing the assembly scan (in addition to your Connectors example, I see a reference in Discovery too and I'm not sure if there are others), but it seems like it could also introduce confusion due to the blind spot it could create...

I'm assuming Connectors wouldn't really work after this change - how does your application handle a silent failure here?

[thompson-tomo]

Hi @TimHess

The example application I included is the shell of my production app where I am encountering the issue. The application works as does the example, my understanding is it is trying to find a dll which doesn't exist due to being published as a single file hence throwing null reference. In the case of single file the library is already loaded.

[TimHess]

Thanks for including the repro, it can be removed from the PR now as this sample can be used for your scenario as well as service discovery.

I think this will work with a few more changes as noted. I pushed a commit that added and updated helper methods that can ensure the contents of these assemblies are not optimized out at build time

[thompson-tomo]

Thanks @TimHess i will review your comments, test the changes on the weekend & come back to you with my results. Hopefully all is successful.

[thompson-tomo]

@TimHess Changes have been made as suggested and all is working as expected in my production app. Let me know if you need anything else from me to get this merged in & it will also need to be ported to v4 release branch.

[TimHess]

LGTM

[TimHess]

/azp run Steeltoe.All

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[sonarcloud]

Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
60.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud