Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AuthenticationBuilder extensions #1286

Merged
merged 1 commit into from
May 6, 2024
Merged

Conversation

TimHess
Copy link
Member

@TimHess TimHess commented Apr 29, 2024

Description

All AddCloudFoundry___ extensions to AuthenticationBuilder should process application configuration and service bindings

Fixes #1275

Quality checklist

  • Your code complies with our Coding Style.
  • You've updated unit and/or integration tests for your change, where applicable.
  • You've updated documentation for your change, where applicable.
    If your change affects other repositories, such as Documentation, Samples and/or MainSite, add linked PRs here.
  • There's an open issue for the PR that you are making. If you'd like to propose a new feature or change, please open an issue to discuss the change or find an existing issue.
  • You've added required license files and/or file headers (explaining where the code came from with proper attribution), where code is copied from StackOverflow, a blog, or OSS.

@TimHess TimHess added Type/bug Something isn't working Component/Security Issues related to Steeltoe Security components (not app-sec) ReleaseLine/3.x Identified as a feature/fix for the 3.x release line labels Apr 29, 2024
@TimHess TimHess added this to the 3.2.7 milestone Apr 29, 2024
@TimHess TimHess self-assigned this Apr 29, 2024
@TimHess
Copy link
Member Author

TimHess commented Apr 29, 2024

/azp run Steeltoe.All

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Copy link

sonarcloud bot commented Apr 29, 2024

Copy link
Member

@bart-vmware bart-vmware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TimHess TimHess merged commit 8ae9892 into release/3.2 May 6, 2024
21 checks passed
@TimHess TimHess deleted the security_extensions branch May 6, 2024 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component/Security Issues related to Steeltoe Security components (not app-sec) ReleaseLine/3.x Identified as a feature/fix for the 3.x release line Type/bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants