Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Utilities for temp files and running commands #693

Merged
merged 1 commit into from
Sep 9, 2021
Merged

Utilities for temp files and running commands #693

merged 1 commit into from
Sep 9, 2021

Conversation

ccheetham
Copy link
Contributor

A general utility library.

Initially contains utilities for working with:

  • temp files and directories
  • running system commands

Usurps PRs #688 and #689.

@ccheetham ccheetham marked this pull request as draft June 16, 2021 14:52
This was referenced Jun 16, 2021
Closed
Closed
@sonarcloud
Copy link

sonarcloud bot commented Jun 16, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@codecov
Copy link

codecov bot commented Jun 16, 2021 •
edited

Codecov Report

Merging #693 (dfc177e) into main (947dfb0) will increase coverage by 0.02%.
The diff coverage is 73.58%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #693      +/-   ##
==========================================
+ Coverage   74.22%   74.24%   +0.02%     
==========================================
  Files        1306     1312       +6     
  Lines       45540    45593      +53     
  Branches     8953     8957       +4     
==========================================
+ Hits        33802    33851      +49     
  Misses       9235     9235              
- Partials     2503     2507       +4
Impacted Files Coverage Δ
...n/src/Common.Utils/Diagnostics/CommandException.cs 50.00% <50.00%> (ø)
src/Common/src/Common.Utils/IO/TempDirectory.cs 63.63% <63.63%> (ø)
src/Common/src/Common.Utils/IO/TempFile.cs 63.63% <63.63%> (ø)
src/Common/src/Common.Utils/IO/TempPath.cs 76.92% <76.92%> (ø)
src/Common/src/Common.Utils/IO/Sandbox.cs 90.00% <90.00%> (ø)
...on/src/Common.Utils/Diagnostics/CommandExecutor.cs 100.00% <100.00%> (ø)
.../src/EndpointCore/Trace/TraceDiagnosticObserver.cs 65.16% <0.00%> (-2.25%) ⬇️
...gement/src/EndpointBase/ThreadDump/ThreadDumper.cs 67.21% <0.00%> (-0.83%) ⬇️
...rc/RabbitMQ/Connection/CachingConnectionFactory.cs 58.29% <0.00%> (-0.26%) ⬇️
... and 11 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 947dfb0...dfc177e. Read the comment docs.

@ccheetham ccheetham marked this pull request as ready for review July 20, 2021 16:24
@TimHess
Copy link
Member

TimHess commented Jul 21, 2021 •
edited

/azp run

@azure-pipelines
Copy link

Pull request contains merge conflicts.

@TimHess
Copy link
Member

TimHess commented Jul 21, 2021

Merge conflict needs to be resolved and solutions for project files that got new project references need to be updated so the new project(s) are included in those solutions too (eg: CircuitBreaker.sln, Configuration.sln, etc)

@TimHess TimHess added Component/Common ReleaseLine/3.x Identified as a feature/fix for the 3.x release line labels Jul 21, 2021
@SteeltoeOSS SteeltoeOSS deleted a comment from azure-pipelines bot Jul 22, 2021
@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@sonarcloud
Copy link

sonarcloud bot commented Jul 29, 2021

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 4 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@TimHess TimHess added this to the 3.2.0 milestone Aug 31, 2021
TimHess
TimHess requested changes Sep 2, 2021
View reviewed changes
Copy link
Member

@TimHess TimHess left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Component .sln files for projects taking the new dependency on Steeltoe.Common.Utils should be updated to include that project

  • CircuitBreaker.sln
  • Configuration.sln
  • Connectors.sln
  • Discovery.sln
  • Logging.sln
  • Management.sln

@sonarcloud
Copy link

sonarcloud bot commented Sep 8, 2021

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 4 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@ccheetham ccheetham merged commit 88857cf into main Sep 9, 2021
@ccheetham ccheetham deleted the common-utils branch September 9, 2021 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TimHess TimHess TimHess approved these changes

Assignees

@ccheetham ccheetham

Labels
Component/Common ReleaseLine/3.x Identified as a feature/fix for the 3.x release line
Projects
None yet
Milestone
3.2.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ccheetham @TimHess