Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gracefully handle missing EF Core ref in DbMigrations #766

Merged
merged 4 commits into from
Sep 21, 2021

Conversation

TimHess
Copy link
Member

@TimHess TimHess commented Sep 7, 2021

Takes care of #741 in 3.2+

Should also be backported to 3.1 and 2.5

@TimHess TimHess added Type/bug Something isn't working Component/Management Issues related to Steeltoe Management (actuators) ReleaseLine/3.x Identified as a feature/fix for the 3.x release line labels Sep 7, 2021
@TimHess TimHess added this to the 3.2.0 milestone Sep 7, 2021
@TimHess TimHess self-assigned this Sep 7, 2021
@TimHess
Copy link
Member Author

TimHess commented Sep 7, 2021

Note: this PR is easier to read if you hide whitespace changes
image

@codecov
Copy link

codecov bot commented Sep 8, 2021

Codecov Report

Merging #766 (7e7deaf) into main (b7da00d) will decrease coverage by 0.06%.
The diff coverage is 75.86%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #766      +/-   ##
==========================================
- Coverage   74.29%   74.23%   -0.07%     
==========================================
  Files        1313     1313              
  Lines       45667    45669       +2     
  Branches     8955     8961       +6     
==========================================
- Hits        33929    33902      -27     
- Misses       9235     9258      +23     
- Partials     2503     2509       +6     
Impacted Files Coverage Δ
.../EndpointBase/DbMigrations/DbMigrationsEndpoint.cs 78.26% <75.00%> (-12.65%) ⬇️
...src/EndpointCore/ActuatorRouteBuilderExtensions.cs 91.52% <100.00%> (ø)
...c/Common/src/Common.Net/WindowsNetworkFileShare.cs 84.21% <0.00%> (-7.02%) ⬇️
.../Listener/DirectReplyToMessageListenerContainer.cs 59.63% <0.00%> (-5.51%) ⬇️
...abbitMQ/Listener/DirectMessageListenerContainer.cs 72.44% <0.00%> (-1.79%) ⬇️
...e/Strategy/Concurrency/HystrixSyncTaskScheduler.cs 85.84% <0.00%> (-1.77%) ⬇️
...rc/RabbitMQ/Connection/CachingConnectionFactory.cs 58.29% <0.00%> (-0.18%) ⬇️
...gement/src/EndpointBase/ThreadDump/ThreadDumper.cs 68.04% <0.00%> (+0.82%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b7da00d...7e7deaf. Read the comment docs.

@sonarcloud
Copy link

sonarcloud bot commented Sep 10, 2021

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@jkonicki
Copy link
Contributor

Needs backport to release/3.1 and release/2.5 branch

Copy link
Contributor

@hananiel hananiel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM;

@TimHess TimHess merged commit 753f633 into main Sep 21, 2021
@TimHess TimHess deleted the timhess/dbmigrationsnull branch September 21, 2021 17:48
TimHess added a commit that referenced this pull request Sep 21, 2021
* Gracefully handle missing EF Core ref in DbMigrations
* split pass/fail actuator auth scenarios into separate tests
* add fix for #729
TimHess added a commit that referenced this pull request Sep 24, 2021
* Gracefully handle missing EF Core ref in DbMigrations (#766)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component/Management Issues related to Steeltoe Management (actuators) ReleaseLine/3.x Identified as a feature/fix for the 3.x release line Type/bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants