Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use 'StringBuilder.Append(char)' instead of 'StringBuilder.Append(str… #793

Merged
merged 3 commits into from
Oct 1, 2021
Merged

Use 'StringBuilder.Append(char)' instead of 'StringBuilder.Append(str… #793

merged 3 commits into from
Oct 1, 2021

Conversation

NemrudDemir
Copy link
Contributor

…ing)'

see #792

@dnfadmin
Copy link

dnfadmin commented Sep 30, 2021 •
edited

CLA assistant check
All CLA requirements met.

@TimHess
Copy link
Member

TimHess commented Oct 1, 2021

/azp run Steeltoe.All

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@TimHess TimHess added Hacktoberfest ReleaseLine/3.x Identified as a feature/fix for the 3.x release line Type/enhancement New feature or request labels Oct 1, 2021
@TimHess TimHess added this to the 3.2.0 milestone Oct 1, 2021
@TimHess TimHess mentioned this pull request Oct 1, 2021
Closed
TimHess
TimHess approved these changes Oct 1, 2021
View reviewed changes
Copy link
Member

@TimHess TimHess left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, should be ok to merge as soon as the build finishes

@sonarcloud
Copy link

sonarcloud bot commented Oct 1, 2021

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@TimHess TimHess merged commit 0764e4f into SteeltoeOSS:main Oct 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TimHess TimHess TimHess approved these changes

Assignees
No one assigned
Labels
ReleaseLine/3.x Identified as a feature/fix for the 3.x release line Type/enhancement New feature or request
Projects
None yet
Milestone
3.2.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@NemrudDemir @dnfadmin @TimHess