Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed complaints for CA1825 #794

Merged
merged 4 commits into from
Oct 1, 2021
Merged

Fixed complaints for CA1825 #794

merged 4 commits into from
Oct 1, 2021

Conversation

Exouxas
Copy link
Contributor

@Exouxas Exouxas commented Oct 1, 2021

Modified all occurrences of zero-length array allocations to use Array.Empty().

Addresses #791

@dnfadmin
Copy link

dnfadmin commented Oct 1, 2021

CLA assistant check
All CLA requirements met.

@TimHess TimHess added Hacktoberfest ReleaseLine/3.x Identified as a feature/fix for the 3.x release line Type/enhancement New feature or request labels Oct 1, 2021
@TimHess TimHess added this to the 3.2.0 milestone Oct 1, 2021
@Exouxas
Copy link
Contributor Author

Exouxas commented Oct 1, 2021

@TimHess I've added using System; now, but I'm a bit confused by the resulting commits. Can you verify that it's correct?

Tried to reset and kept changes so it would all be in one commit, but it looks like it created 2 commits and 1 merge instead..

@Exouxas Exouxas requested a review from TimHess October 1, 2021 12:01
@TimHess
Copy link
Member

TimHess commented Oct 1, 2021

@TimHess I've added using System; now, but I'm a bit confused by the resulting commits. Can you verify that it's correct?

Tried to reset and kept changes so it would all be in one commit, but it looks like it created 2 commits and 1 merge instead..

Sorry about the confusion there - I had merged another (important, pipeline-related) commit in main and then pushed the update button here.. I'll squash during the merge so it'll only be 1 commit in the end and nothing to worry about

@TimHess
Copy link
Member

TimHess commented Oct 1, 2021

/azp run Steeltoe.All

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Copy link
Member

@TimHess TimHess left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@sonarcloud
Copy link

sonarcloud bot commented Oct 1, 2021

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@TimHess TimHess merged commit 4c4947d into SteeltoeOSS:main Oct 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ReleaseLine/3.x Identified as a feature/fix for the 3.x release line Type/enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants