Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support .NET 6, update OTel #812

Merged
merged 4 commits into from
Dec 3, 2021
Merged

Support .NET 6, update OTel #812

merged 4 commits into from
Dec 3, 2021

Conversation

TimHess
Copy link
Member

@TimHess TimHess commented Nov 19, 2021

  • Update projects and pipeline to build or test .NET 6 as necessary
  • Include .NET 6 fixes already in main
  • Upgrade OTel to 1.2 beta to get around restriction of < 6.0.0 for Microsoft.Extensions.Logging

@TimHess
support .net 6, update otel
743b7ab 
drop redundant ref

net6 issues

fix copypasta

allow more time to complete builds
@TimHess TimHess added the ReleaseLine/3.x Identified as a feature/fix for the 3.x release line label Nov 19, 2021
@TimHess TimHess added this to the 3.1.2 milestone Nov 19, 2021
@TimHess TimHess self-assigned this Nov 19, 2021
@TimHess
Copy link
Member Author

TimHess commented Nov 19, 2021 •
edited

/azp run Steeltoe.All

@TimHess
Copy link
Member Author

TimHess commented Dec 1, 2021 •
edited

This PR (and a 3.1.2 release) are going to hold for a bit longer in hopes that the Open Telemetry metrics spec can be finalized in short order and a GA of OTel 1.2.0 can be released
OTel 1.2 is only used for .NET 6 apps, and those applications should be able to use 1.2.0 GA if/when it is released

hananiel
hananiel reviewed Dec 2, 2021
View reviewed changes
versions.props Outdated Show resolved Hide resolved
@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@SteeltoeOSS SteeltoeOSS deleted a comment from azure-pipelines bot Dec 2, 2021
@SteeltoeOSS SteeltoeOSS deleted a comment from azure-pipelines bot Dec 2, 2021
@SteeltoeOSS SteeltoeOSS deleted a comment from sonarcloud bot Dec 2, 2021
@SteeltoeOSS SteeltoeOSS deleted a comment from azure-pipelines bot Dec 2, 2021
@sonarcloud
Copy link

sonarcloud bot commented Dec 3, 2021

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 12 Code Smells

89.2% 89.2% Coverage
11.1% 11.1% Duplication

@TimHess TimHess requested a review from hananiel December 3, 2021 19:42
@TimHess TimHess merged commit 1492e83 into release/3.1 Dec 3, 2021
@TimHess TimHess deleted the net6on3.1 branch December 3, 2021 21:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hananiel hananiel hananiel approved these changes

@dtillman dtillman Awaiting requested review from dtillman

Assignees

@TimHess TimHess

Labels
ReleaseLine/3.x Identified as a feature/fix for the 3.x release line
Projects
None yet
Milestone
3.1.2
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@TimHess @hananiel