Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CORS response should allow Content-Disposition header on CF #836

Merged
merged 1 commit into from
Apr 6, 2022
Merged

CORS response should allow Content-Disposition header on CF #836

merged 1 commit into from
Apr 6, 2022

Conversation

TimHess
Copy link
Member

@TimHess TimHess commented Apr 6, 2022 •
edited

For use with heap dumps in particular

@TimHess TimHess added Type/enhancement New feature or request Component/Management Issues related to Steeltoe Management (actuators) ReleaseLine/3.x Identified as a feature/fix for the 3.x release line labels Apr 6, 2022
@TimHess TimHess added this to the 3.2.0 milestone Apr 6, 2022
@TimHess TimHess self-assigned this Apr 6, 2022
ccheetham
ccheetham approved these changes Apr 6, 2022
View reviewed changes
Copy link
Contributor

@ccheetham ccheetham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@TimHess
Copy link
Member Author

TimHess commented Apr 6, 2022

/azp run Steeltoe.All

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@sonarcloud
Copy link

sonarcloud bot commented Apr 6, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@TimHess TimHess merged commit 629085b into main Apr 6, 2022
TimHess added a commit that referenced this pull request Apr 6, 2022
@TimHess
CORS response should allow Content-Disposition header on CF (#836)
2ac2a57
TimHess added a commit that referenced this pull request Apr 6, 2022
@TimHess
CORS response should allow Content-Disposition header on CF (#836)
e22e087
TimHess added a commit that referenced this pull request Apr 7, 2022
@TimHess
Merge pull request #837 from SteeltoeOSS/backport_836_3.1
f2c4b80 
Backport #836 to release/3.1
@TimHess TimHess deleted the content-disposition branch May 24, 2022 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ccheetham ccheetham ccheetham approved these changes

@hananiel hananiel hananiel approved these changes

Assignees

@TimHess TimHess

Labels
Component/Management Issues related to Steeltoe Management (actuators) ReleaseLine/3.x Identified as a feature/fix for the 3.x release line Type/enhancement New feature or request
Projects
None yet
Milestone
3.2.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@TimHess @ccheetham @hananiel