Metrics 3 versions #842
Merged
Metrics 3 versions #842
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Tim Hess <thess@vmware.com>
…nto WavefrontExporter
hananiel
added
the
Component/Management
hananiel
force-pushed
the
Metrics_3_versions
branch
from
0be1291
to
5b87573
Compare
|
It looks like there is now a GA release of the core components |
TimHess
reviewed
Apr 26, 2022
| @@ -253,6 +254,23 @@ public void AllActuators_AreAutowired() | |||
| Assert.IsType<AllActuatorsStartupFilter>(filter); | |||
| } | |||
|
|
|||
| [Fact] | |||
| public void Wavefront_IsAutowired() | |||
There was a problem hiding this comment.
Should this be two separate tests?
There was a problem hiding this comment.
I wonder if anyone would want to enable metrics but not traces or vice versa, at the moment thats not an option. Thats mostly why its the same test.
There was a problem hiding this comment.
What would happen if you have a ref for EndpointCore (and Wavefront config) but not TracingCore?
There was a problem hiding this comment.
It works as expected, adding two separate tests.
TimHess
reviewed
Apr 26, 2022
TimHess
reviewed
Apr 26, 2022
src/Management/src/OpenTelemetryBase/Exporters/Wavefront/WavefrontTraceExporter.cs
Show resolved
Hide resolved
TimHess
reviewed
Apr 26, 2022
TimHess
reviewed
Apr 26, 2022
| /// </summary> | ||
| /// <param name="hostBuilder">Your hostBuilder</param> | ||
| /// <returns>The configured hostBuilder</returns> | ||
| public static IHostBuilder AddDistributedTracing(this IHostBuilder hostBuilder) |
There was a problem hiding this comment.
Action<TracerProviderBuilder> action could be exposed here too
|
/azp run Steeltoe.All |
|
Azure Pipelines successfully started running 1 pipeline(s). |
TimHess
reviewed
Apr 27, 2022
src/Bootstrap/test/Autoconfig.Test/WebHostBuilderExtensionsTest.cs
Outdated
Show resolved
Hide resolved
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
SonarCloud Quality Gate failed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update to GA of OpenTelemetry Core packages & latest RC of non core
Add support for Proxy (without needing telegraf) and compatible with boot experience
Add support for wavefront with AddSteeltoe autoconfiguration