Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create a PR for issue-840 #847

Merged
merged 6 commits into from
May 20, 2022
Merged

Create a PR for issue-840 #847

merged 6 commits into from
May 20, 2022

Conversation

deepakapj
Copy link
Contributor

Fix for Hystrix dashboard doesn't load Metrics DOTNET 6.0

@deepakapj
Create a PR for issue-840
cbebba6 
Fix for Hystrix dashboard doesn't load Metrics DOTNET 6.0
@dnfadmin
Copy link

dnfadmin commented May 12, 2022 •
edited

CLA assistant check
All CLA requirements met.

@deepakapj deepakapj mentioned this pull request May 12, 2022
Closed
@dtillman
Copy link
Contributor

@deepakapj : Thanks .. LGTM... can you please sign CLA .. thanks again!

@TimHess
Copy link
Member

TimHess commented May 19, 2022 •
edited

/azp run Steeltoe.All

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

TimHess
TimHess reviewed May 19, 2022
View reviewed changes
Copy link
Member

@TimHess TimHess left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add comments to clear warnings

src/CircuitBreaker/src/HystrixBase/Serial/SerialHystrixDashboardData.cs Outdated Show resolved Hide resolved
src/CircuitBreaker/src/HystrixBase/Serial/SerialHystrixDashboardData.cs Show resolved Hide resolved
src/CircuitBreaker/src/HystrixBase/Serial/SerialHystrixDashboardData.cs Show resolved Hide resolved
@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@TimHess TimHess requested a review from dtillman May 19, 2022 20:29
@TimHess TimHess added this to the 3.2.0 milestone May 19, 2022
@TimHess TimHess added Type/bug Something isn't working Component/CircuitBreaker Issues related to Steeltoe.CircuitBreaker labels May 19, 2022
@sonarcloud
Copy link

sonarcloud bot commented May 19, 2022

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

22.2% 22.2% Coverage
0.0% 0.0% Duplication

@deepakapj
Copy link
Contributor Author

Hi Tim & Team,

Any item pending from my side. Please let me know.

Thanks
Deepak Saxena

@TimHess TimHess merged commit 2618f58 into SteeltoeOSS:main May 20, 2022
@TimHess
Copy link
Member

TimHess commented May 20, 2022

All set here, thanks @deepakapj

@deepakapj
Copy link
Contributor Author

Hi @TimHess & @dtillman ,

Could you please add this for 3.2 pre-release or release so that we can use in our project? This is blocker to release our project.
if this is part 3.2 pre-release then we can start development.

Thanks,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TimHess TimHess TimHess left review comments

@dtillman dtillman dtillman approved these changes

Assignees
No one assigned
Labels
Component/CircuitBreaker Issues related to Steeltoe.CircuitBreaker Type/bug Something isn't working
Projects
None yet
Milestone
3.2.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@deepakapj @dnfadmin @dtillman @TimHess