-
Notifications
You must be signed in to change notification settings - Fork 160
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make Steeltoe Metrics extensions play nice with Otel #848
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hananiel
added
the
Component/Management
Issues related to Steeltoe Management (actuators)
label
May 12, 2022
TimHess
reviewed
May 20, 2022
src/Management/src/EndpointBase/Metrics/ServiceCollectionExtensions.cs
Outdated
Show resolved
Hide resolved
src/Management/src/EndpointBase/Metrics/ServiceCollectionExtensions.cs
Outdated
Show resolved
Hide resolved
src/Management/src/OpenTelemetryBase/Exporters/Wavefront/WavefrontExporterOptions.cs
Show resolved
Hide resolved
src/Management/src/EndpointBase/Metrics/ServiceCollectionExtensions.cs
Outdated
Show resolved
Hide resolved
src/Management/src/EndpointBase/Metrics/ServiceCollectionExtensions.cs
Outdated
Show resolved
Hide resolved
src/Management/src/EndpointCore/Metrics/EndpointServiceCollectionExtensions.cs
Outdated
Show resolved
Hide resolved
Co-authored-by: Tim Hess <thess@vmware.com>
/azp run Steeltoe.All |
Azure Pipelines successfully started running 1 pipeline(s). |
TimHess
reviewed
May 25, 2022
TimHess
reviewed
May 25, 2022
src/Management/src/EndpointBase/Metrics/ServiceCollectionExtensions.cs
Outdated
Show resolved
Hide resolved
…oeOSS/Steeltoe into SteeltoeMetrics_OtelCompatibility
TimHess
approved these changes
May 25, 2022
Azure Pipelines successfully started running 1 pipeline(s). |
Kudos, SonarCloud Quality Gate passed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Final version:
AddOpenTelemetryMetricsForSteeltoe
viaAddAllActuators
, a warning is written to Console and Steeltoe configuration will be ignored. Callingmetrics
,prometheus
will not produce any metrics, and a warning will be logged.AddAllActuators
first, and then call Otel viaAddOpenTelemetryMetrics
, Otel configuration will take precedence and Steeltoe configuration will be ignored. There will be no warning, because we don't have an opportunity to detect this. Calling metrics, prometheus will not produce any metrics, and a warning will be logged.This will start logging Steeltoe Observer metrics to console and prometheus and metrics endpoints will work correctly.