Fixed a few tests that didn't assert on the outcome #849
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bart-vmware
added
the
Warn/breaking-change
|
/azp run Steeltoe.All |
|
Azure Pipelines successfully started running 1 pipeline(s). |
hananiel
approved these changes
May 16, 2022
|
/azp run Steeltoe.All |
|
Azure Pipelines successfully started running 1 pipeline(s). |
hananiel
reviewed
May 19, 2022
| labels.Contains(KeyValuePair.Create("method", (object)"GET")); | ||
|
|
||
| Assert.Contains(KeyValuePair.Create("clientName", (object)"localhost:5555"), labels); | ||
| Assert.Contains(KeyValuePair.Create("uri", (object)"/foo/bar"), labels); |
There was a problem hiding this comment.
This is the correct assertion. And the code change is correct.
|
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Kudos, SonarCloud Quality Gate passed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While looking at warnings from Resharper, I found some tests that didn't assert on the outcome.
After correcting these tests, some of them failed. I've adapted the target logic accordingly to make the tests succeed without changing their assumptions.
Note this is a breaking change. If taking a breaking change is not an option, we should adapt the tests instead to match the current behavior.