Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix local cert generation for TAS not including all oids #869

Merged
merged 1 commit into from
Jul 26, 2022
Merged

Fix local cert generation for TAS not including all oids #869

merged 1 commit into from
Jul 26, 2022

Conversation

macsux
Copy link
Contributor

@macsux macsux commented Jun 7, 2022

Fix local cert generation for TAS not including all oids (preventing usage for kestrel server when using contrainer-to-container with ssl)

@macsux
Copy link
Contributor Author

macsux commented Jun 7, 2022

I would like to request that this be included in the next patch to 3.2 branch as well as it affects a demo we have for TAS.

@TimHess
Copy link
Member

TimHess commented Jun 7, 2022 •
edited

/azp run Steeltoe.All

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

1 similar comment
@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@TimHess
Copy link
Member

TimHess commented Jun 7, 2022

@macsux test failing on Linux & Mac: System.Security.Cryptography.CryptographicException : No OID value matches this name.

@azure-pipelines
Copy link

Pull request contains merge conflicts.

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@sonarcloud
Copy link

sonarcloud bot commented Jun 10, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@TimHess
Copy link
Member

TimHess commented Jun 10, 2022 •
edited

@macsux new issue in tests (showing up on Mac, Linux and Windows):

System.AggregateException : One or more errors occurred. (An X509Extension with OID '2.5.29.37' has already been specified.) (The following constructor parameters did not have matching fixture data: ClientCertificatesFixture fixture)
---- System.InvalidOperationException : An X509Extension with OID '2.5.29.37' has already been specified.
---- The following constructor parameters did not have matching fixture data: ClientCertificatesFixture fixture

@macsux
Fix local cert generation for TAS not including all oids (preventing …
b0258da 
…usage for kestrel server when using contrainer-to-container with ssl)
@macsux macsux force-pushed the bug/cf-cert-extended-usage branch from 0af73d5 to b0258da Compare July 26, 2022 18:11
@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@TimHess
Copy link
Member

TimHess commented Jul 26, 2022

Note: should backport to release/3.2

@TimHess TimHess added this to the 4.0.0-alpha milestone Jul 26, 2022
@TimHess TimHess added Type/enhancement New feature or request Component/Common labels Jul 26, 2022
@macsux
Copy link
Contributor Author

macsux commented Jul 26, 2022

/azp run Steeltoe.All

@azure-pipelines
Copy link

Commenter does not have sufficient privileges for PR 869 in repo SteeltoeOSS/Steeltoe

@sonarcloud
Copy link

sonarcloud bot commented Jul 26, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@TimHess TimHess self-assigned this Jul 26, 2022
@TimHess TimHess merged commit a11ef1c into SteeltoeOSS:main Jul 26, 2022
TimHess added a commit that referenced this pull request Jul 26, 2022
@TimHess
Fix local cert generation for TAS not including all oids (preventing …
b70b546 
…usage for kestrel server when using container-to-container with ssl) (#869)
@TimHess TimHess mentioned this pull request Jul 26, 2022
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TimHess TimHess TimHess approved these changes

Assignees

@TimHess TimHess

Labels
Component/Common Type/enhancement New feature or request
Projects
None yet
Milestone
4.0.0-m1
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@macsux @TimHess