Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use Eureka proxy & decompression settings in HttpClientFactory setup #880

Merged
merged 2 commits into from
Jul 11, 2022
Merged

use Eureka proxy & decompression settings in HttpClientFactory setup #880

merged 2 commits into from
Jul 11, 2022

Conversation

TimHess
Copy link
Member

@TimHess TimHess commented Jul 5, 2022 •
edited

Description

Fix bug introduced in #778 where client settings (like AutomaticDecompression and proxy config) aren't applied during HttpClientFactory setup

Addresses #865, and will need to be backported to release/3.2

Quality checklist

  • Your code complies with our Coding Style.
  • You've updated unit and/or integration tests for your change, where applicable.
  • You've updated documentation for your change, where applicable.
    If your change affects other repositories, such as Documentation, Samples and/or MainSite, add linked PRs here.
  • There's an open issue for the PR that you are making. If you'd like to propose a new feature or change, please open an issue to discuss the change or find an existing issue.
  • You've added required license files and/or file headers (explaining where the code came from with proper attribution), where code is copied from StackOverflow, a blog, or OSS.

@TimHess TimHess added Type/bug Something isn't working Component/Discovery Issues related to Steeltoe Service Discovery ReleaseLine/4.x Identified as a feature/fix for the 4.x release line labels Jul 5, 2022
@TimHess TimHess added this to the 4.0.0-alpha milestone Jul 5, 2022
@TimHess TimHess requested review from hananiel and dtillman July 5, 2022 18:52
@TimHess TimHess self-assigned this Jul 5, 2022
@TimHess
Copy link
Member Author

TimHess commented Jul 5, 2022 •
edited

/azp run Steeltoe.All

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@TimHess TimHess marked this pull request as ready for review July 5, 2022 21:08
dtillman
dtillman approved these changes Jul 6, 2022
View reviewed changes
Copy link
Contributor

@dtillman dtillman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@sonarcloud
Copy link

sonarcloud bot commented Jul 11, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

88.0% 88.0% Coverage
0.0% 0.0% Duplication

@TimHess TimHess merged commit 82a9725 into main Jul 11, 2022
@TimHess TimHess deleted the use_eureka_client_options branch July 11, 2022 22:18
@TimHess TimHess mentioned this pull request Jul 22, 2022
Merged
5 tasks
TimHess added a commit that referenced this pull request Jul 22, 2022
@TimHess
use Eureka proxy & decompression settings in HttpClientFactory setup (#…
5ed9a6e 
…880)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dtillman dtillman dtillman approved these changes

@hananiel hananiel Awaiting requested review from hananiel

Assignees

@TimHess TimHess

Labels
Component/Discovery Issues related to Steeltoe Service Discovery ReleaseLine/4.x Identified as a feature/fix for the 4.x release line Type/bug Something isn't working
Projects
None yet
Milestone
4.0.0-m1
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@TimHess @dtillman