Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle wrapping PlaceholderResolverProvider in ConfigServerHostedService #881

Merged
merged 7 commits into from
Jul 14, 2022
Merged

Handle wrapping PlaceholderResolverProvider in ConfigServerHostedService #881

merged 7 commits into from
Jul 14, 2022

Conversation

TimHess
Copy link
Member

@TimHess TimHess commented Jul 5, 2022 •
edited

Description

Handle the situation where ConfigServerHostedService is given an IConfigurationRoot where the PlaceholderResolverProvider wraps the ConfigServerConfigurationProvider

Addresses #879, needs backport to release/3.2

Quality checklist

  • Your code complies with our Coding Style.
  • You've updated unit and/or integration tests for your change, where applicable.
  • You've updated documentation for your change, where applicable.
    If your change affects other repositories, such as Documentation, Samples and/or MainSite, add linked PRs here.
  • There's an open issue for the PR that you are making. If you'd like to propose a new feature or change, please open an issue to discuss the change or find an existing issue.
  • You've added required license files and/or file headers (explaining where the code came from with proper attribution), where code is copied from StackOverflow, a blog, or OSS.

@TimHess TimHess added Type/bug Something isn't working Component/Configuration Issues related to Configuration providers ReleaseLine/4.x Identified as a feature/fix for the 4.x release line labels Jul 5, 2022
@TimHess TimHess self-assigned this Jul 5, 2022
@TimHess
Copy link
Member Author

TimHess commented Jul 5, 2022 •
edited

/azp run Steeltoe.All

@TimHess TimHess marked this pull request as ready for review July 5, 2022 21:07
@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@TimHess TimHess added this to the 4.0.0-alpha milestone Jul 5, 2022
@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

bart-vmware and others added 3 commits July 13, 2022 16:09
@bart-vmware @TimHess
Update src/Configuration/test/ConfigServerBase.Test/ConfigServerHoste…
87dfd45 
…dServiceTest.cs

Co-authored-by: Tim Hess <thess@vmware.com>
@bart-vmware @TimHess
Update src/Configuration/test/ConfigServerBase.Test/ConfigServerHoste…
c2b1f7f 
…dServiceTest.cs

Co-authored-by: Tim Hess <thess@vmware.com>
@bart-vmware @TimHess
Update src/Configuration/src/ConfigServerBase/ConfigServerHostedServi…
2c36717 
…ce.cs

Co-authored-by: Tim Hess <thess@vmware.com>
bart-vmware
bart-vmware previously approved these changes Jul 13, 2022
View reviewed changes
bart-vmware
bart-vmware previously approved these changes Jul 13, 2022
View reviewed changes
@TimHess TimHess requested a review from bart-vmware July 13, 2022 14:22
@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@sonarcloud
Copy link

sonarcloud bot commented Jul 13, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

bart-vmware
bart-vmware approved these changes Jul 14, 2022
View reviewed changes
Copy link
Member

@bart-vmware bart-vmware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TimHess TimHess merged commit b1772a5 into main Jul 14, 2022
@TimHess TimHess deleted the bug/879 branch July 14, 2022 13:11
@TimHess TimHess mentioned this pull request Jul 22, 2022
Merged
5 tasks
TimHess added a commit that referenced this pull request Jul 22, 2022
@TimHess
Handle wrapping PlaceholderResolverProvider in ConfigServerHostedServ…
6b8b9db 
…ice (#881)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bart-vmware bart-vmware bart-vmware approved these changes

@dtillman dtillman Awaiting requested review from dtillman

@hananiel hananiel Awaiting requested review from hananiel

Assignees

@TimHess TimHess

Labels
Component/Configuration Issues related to Configuration providers ReleaseLine/4.x Identified as a feature/fix for the 4.x release line Type/bug Something isn't working
Projects
None yet
Milestone
4.0.0-m1
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@TimHess @bart-vmware