Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle null ref in Eureka setup in CF when app has no Uri #892

Merged
merged 4 commits into from
Jul 26, 2022
Merged

Handle null ref in Eureka setup in CF when app has no Uri #892

merged 4 commits into from
Jul 26, 2022

Conversation

TimHess
Copy link
Member

@TimHess TimHess commented Jul 22, 2022 •
edited

Description

Resolves a null reference issue with Eureka config on Cloud Foundry when no Uri has been assigned to the app
Deals with #872 -- backport to release/3.2 in order to completely resolve

Quality checklist

  • Your code complies with our Coding Style.
  • You've updated unit and/or integration tests for your change, where applicable.
  • You've updated documentation for your change, where applicable.
    If your change affects other repositories, such as Documentation, Samples and/or MainSite, add linked PRs here.
  • There's an open issue for the PR that you are making. If you'd like to propose a new feature or change, please open an issue to discuss the change or find an existing issue.
  • You've added required license files and/or file headers (explaining where the code came from with proper attribution), where code is copied from StackOverflow, a blog, or OSS.

@TimHess TimHess added Type/bug Something isn't working Component/Discovery Issues related to Steeltoe Service Discovery labels Jul 22, 2022
@TimHess TimHess added this to the 4.0.0-alpha milestone Jul 22, 2022
@TimHess TimHess self-assigned this Jul 22, 2022
@TimHess
Copy link
Member Author

TimHess commented Jul 22, 2022 •
edited

/azp run Steeltoe.All

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

bart-vmware
bart-vmware reviewed Jul 25, 2022
View reviewed changes
Copy link
Member

@bart-vmware bart-vmware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

src/Discovery/test/Eureka.Test/EurekaPostConfigurerTest.cs Outdated Show resolved Hide resolved
@TimHess TimHess requested a review from bart-vmware July 25, 2022 18:24
@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@TimHess TimHess changed the title handle null ref in Eureka setup in CF when app has no Uri Handle null ref in Eureka setup in CF when app has no Uri Jul 26, 2022
@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@sonarcloud
Copy link

sonarcloud bot commented Jul 26, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@TimHess TimHess merged commit f5166ef into main Jul 26, 2022
@TimHess TimHess deleted the bug/872 branch July 26, 2022 14:47
TimHess added a commit that referenced this pull request Jul 26, 2022
@TimHess
Handle null ref in Eureka setup in CF when app has no Uri (#892)
5e1935d
@TimHess TimHess mentioned this pull request Jul 26, 2022
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bart-vmware bart-vmware bart-vmware approved these changes

@dtillman dtillman Awaiting requested review from dtillman

@hananiel hananiel Awaiting requested review from hananiel

Assignees

@TimHess TimHess

Labels
Component/Discovery Issues related to Steeltoe Service Discovery Type/bug Something isn't working
Projects
None yet
Milestone
4.0.0-m1
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@TimHess @bart-vmware