Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add StructuredMessageProcessingLogger #986

Merged
merged 3 commits into from
Aug 16, 2022
Merged

Add StructuredMessageProcessingLogger #986

merged 3 commits into from
Aug 16, 2022

Conversation

hananiel
Copy link
Contributor

Description

Handle structured Logs correctly when using Serilog.

Fixes #895

Quality checklist

  • Your code complies with our Coding Style.
  • You've updated unit and/or integration tests for your change, where applicable.
  • You've updated documentation for your change, where applicable.
    If your change affects other repositories, such as Documentation, Samples and/or MainSite, add linked PRs.
    Need to add a sample or update existing sample to cover this scenario specifically with tracing.
  • There's an open issue for the PR that you are making. If you'd like to propose a new feature or change, please open an issue to discuss the change or find an existing issue.
  • You've added required license files and/or file headers (explaining where the code came from with proper attribution), where code is copied from StackOverflow, a blog, or OSS.

@hananiel hananiel changed the base branch from main to release/3.2 August 10, 2022 21:22
@hananiel hananiel changed the title Log structured messageprocessor Add StructuredMessageProcessingLogger Aug 10, 2022
@hananiel hananiel self-assigned this Aug 10, 2022
@TimHess TimHess added this to the 3.2.2 milestone Aug 16, 2022
@TimHess TimHess added Type/bug Something isn't working ReleaseLine/3.x Identified as a feature/fix for the 3.x release line Component/Logging Issues related to Dynamic Logging labels Aug 16, 2022
@TimHess
Copy link
Member

TimHess commented Aug 16, 2022 •
edited

/azp run Steeltoe.All

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

TimHess
TimHess requested changes Aug 16, 2022
View reviewed changes
Copy link
Member

@TimHess TimHess left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor cleanup, looks good otherwise

src/Logging/src/Abstractions/StructuredMessageProcessingLogger.cs Outdated Show resolved Hide resolved
@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

TimHess
TimHess approved these changes Aug 16, 2022
View reviewed changes
Copy link
Member

@TimHess TimHess left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sonarcloud
Copy link

sonarcloud bot commented Aug 16, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

71.4% 71.4% Coverage
0.0% 0.0% Duplication

@hananiel hananiel merged commit 43b96ce into release/3.2 Aug 16, 2022
@hananiel hananiel deleted the log_structured_messageprocessor branch August 16, 2022 22:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TimHess TimHess TimHess approved these changes

@bart-vmware bart-vmware Awaiting requested review from bart-vmware

@ccheetham ccheetham Awaiting requested review from ccheetham

@dtillman dtillman Awaiting requested review from dtillman

Assignees

@hananiel hananiel

Labels
Component/Logging Issues related to Dynamic Logging ReleaseLine/3.x Identified as a feature/fix for the 3.x release line Type/bug Something isn't working
Projects
None yet
Milestone
3.2.2
Development

Successfully merging this pull request may close these issues.

Steeltoe 3.2.0 breaks Serilog structured logging
2 participants
@hananiel @TimHess