Implementation of Story #26, #27 and #28 #41
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…add-rating page
…ckable like the entire radiobutton
…ight and reused code in role-checkbox, added label so that clicking on description/heading also checks the radiobutton.
…ke it clickable. Completed story #26
…ding date of conference as sort criteria.
… part of date being cut off in some cases
|
thanks for the help! |
|
All the stories you mention are done and can be closed, right? |
|
Yes maybe look over them and do a little QA, but they should be done. Am 11/24/15 um 8:29 AM schrieb Florian Sellmayr:
Immo Stanke ThoughtWorks Deutschland GmbH - Großer Burstah 46-48 - D-20457 Hamburg Sitz der Gesellschaft: Hamburg - Geschäftsführer: Dr. Peter Buhrmann - AG Hamburg - HRB 115336 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We implemented Story #26, #27 and #28 so that you can now click on the labels of radiobuttons and checkboxes as well as their symbols to select or check/uncheck them. For the "I would go again" checkbox, the entire orange area is clickable.
Furthermore, we refactored some duplicated code between role-checkbox and tag-checkbox.