Add missing endpoint #165
Merged
Add missing endpoint #165
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # stellar_base/address.py
overcat
reviewed
Oct 24, 2018
tests/test_asset.py
Outdated
| assert former_xdr_cny.code == self.cny.code, 'Padding not removed.' | ||
|
|
||
| # check for greater than four as well ... | ||
| xdr = Asset('BIGGER').to_xdr_object() |
There was a problem hiding this comment.
Need to provide an asset issuer.
There was a problem hiding this comment.
I think this test is unnecessary.
Codecov Report
@@ Coverage Diff @@
## master #165 +/- ##
=========================================
- Coverage 82.1% 81.91% -0.2%
=========================================
Files 24 24
Lines 2056 2062 +6
=========================================
+ Hits 1688 1689 +1
- Misses 368 373 +5
|
|
Thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added the https://www.stellar.org/developers/horizon/reference/endpoints/trades-for-account.html endpoint. I included a test that i had with this padding removing i had the fix for that as well but it was already done in the meantime.