Fix overflow on bad implementations of tanh()

Fixes #3351
Stellarium · Aug 4, 2023 · 3555e61 · 3555e61
1 parent 2d0e8c7
commit 3555e61
Show file tree

Hide file tree

Showing 31 changed files with 93 additions and 31 deletions.
diff --git a/atmosphere/default/shaders/double-scattering-eclipsed/precomputed/render.frag b/atmosphere/default/shaders/double-scattering-eclipsed/precomputed/render.frag
@@ -274,8 +274,10 @@ void main()
         // The first factor here, with dot(view,sun), results in removal of the
         // forward scattering peak. The second factor, with tanh, makes the
         // transition near sunset from a bit above horizon to a bit below smoother.
+        // We limit the argument of tanh, because some GLSL implementations (e.g.
+        // AMD Radeon RX 5700 XT) overflow when computing it and yield NaN.
         pseudoMirrorDepth = sqr(max(0, dot(viewDir, sunDirection))) *
-                               tanh(150 * (newViewElev - horizElev) / (PI/2 - horizElev));
+                               tanh(min(10, 150 * (newViewElev - horizElev) / (PI/2 - horizElev)));
     }
 
     CONST float cosSunZenithAngle =dot(zenith,sunDirection);

diff --git a/atmosphere/default/shaders/eclipsed-zero-order-scattering/0/render.frag b/atmosphere/default/shaders/eclipsed-zero-order-scattering/0/render.frag
@@ -293,8 +293,10 @@ void main()
         // The first factor here, with dot(view,sun), results in removal of the
         // forward scattering peak. The second factor, with tanh, makes the
         // transition near sunset from a bit above horizon to a bit below smoother.
+        // We limit the argument of tanh, because some GLSL implementations (e.g.
+        // AMD Radeon RX 5700 XT) overflow when computing it and yield NaN.
         pseudoMirrorDepth = sqr(max(0, dot(viewDir, sunDirection))) *
-                               tanh(150 * (newViewElev - horizElev) / (PI/2 - horizElev));
+                               tanh(min(10, 150 * (newViewElev - horizElev) / (PI/2 - horizElev)));
     }
 
     CONST float cosSunZenithAngle =dot(zenith,sunDirection);

diff --git a/atmosphere/default/shaders/eclipsed-zero-order-scattering/1/render.frag b/atmosphere/default/shaders/eclipsed-zero-order-scattering/1/render.frag
@@ -293,8 +293,10 @@ void main()
         // The first factor here, with dot(view,sun), results in removal of the
         // forward scattering peak. The second factor, with tanh, makes the
         // transition near sunset from a bit above horizon to a bit below smoother.
+        // We limit the argument of tanh, because some GLSL implementations (e.g.
+        // AMD Radeon RX 5700 XT) overflow when computing it and yield NaN.
         pseudoMirrorDepth = sqr(max(0, dot(viewDir, sunDirection))) *
-                               tanh(150 * (newViewElev - horizElev) / (PI/2 - horizElev));
+                               tanh(min(10, 150 * (newViewElev - horizElev) / (PI/2 - horizElev)));
     }
 
     CONST float cosSunZenithAngle =dot(zenith,sunDirection);

diff --git a/atmosphere/default/shaders/eclipsed-zero-order-scattering/2/render.frag b/atmosphere/default/shaders/eclipsed-zero-order-scattering/2/render.frag
@@ -293,8 +293,10 @@ void main()
         // The first factor here, with dot(view,sun), results in removal of the
         // forward scattering peak. The second factor, with tanh, makes the
         // transition near sunset from a bit above horizon to a bit below smoother.
+        // We limit the argument of tanh, because some GLSL implementations (e.g.
+        // AMD Radeon RX 5700 XT) overflow when computing it and yield NaN.
         pseudoMirrorDepth = sqr(max(0, dot(viewDir, sunDirection))) *
-                               tanh(150 * (newViewElev - horizElev) / (PI/2 - horizElev));
+                               tanh(min(10, 150 * (newViewElev - horizElev) / (PI/2 - horizElev)));
     }
 
     CONST float cosSunZenithAngle =dot(zenith,sunDirection);

diff --git a/atmosphere/default/shaders/eclipsed-zero-order-scattering/3/render.frag b/atmosphere/default/shaders/eclipsed-zero-order-scattering/3/render.frag
@@ -293,8 +293,10 @@ void main()
         // The first factor here, with dot(view,sun), results in removal of the
         // forward scattering peak. The second factor, with tanh, makes the
         // transition near sunset from a bit above horizon to a bit below smoother.
+        // We limit the argument of tanh, because some GLSL implementations (e.g.
+        // AMD Radeon RX 5700 XT) overflow when computing it and yield NaN.
         pseudoMirrorDepth = sqr(max(0, dot(viewDir, sunDirection))) *
-                               tanh(150 * (newViewElev - horizElev) / (PI/2 - horizElev));
+                               tanh(min(10, 150 * (newViewElev - horizElev) / (PI/2 - horizElev)));
     }
 
     CONST float cosSunZenithAngle =dot(zenith,sunDirection);

diff --git a/atmosphere/default/shaders/light-pollution/render.frag b/atmosphere/default/shaders/light-pollution/render.frag
@@ -286,8 +286,10 @@ void main()
         // The first factor here, with dot(view,sun), results in removal of the
         // forward scattering peak. The second factor, with tanh, makes the
         // transition near sunset from a bit above horizon to a bit below smoother.
+        // We limit the argument of tanh, because some GLSL implementations (e.g.
+        // AMD Radeon RX 5700 XT) overflow when computing it and yield NaN.
         pseudoMirrorDepth = sqr(max(0, dot(viewDir, sunDirection))) *
-                               tanh(150 * (newViewElev - horizElev) / (PI/2 - horizElev));
+                               tanh(min(10, 150 * (newViewElev - horizElev) / (PI/2 - horizElev)));
     }
 
     CONST float cosSunZenithAngle =dot(zenith,sunDirection);

diff --git a/atmosphere/default/shaders/multiple-scattering/render.frag b/atmosphere/default/shaders/multiple-scattering/render.frag
@@ -274,8 +274,10 @@ void main()
         // The first factor here, with dot(view,sun), results in removal of the
         // forward scattering peak. The second factor, with tanh, makes the
         // transition near sunset from a bit above horizon to a bit below smoother.
+        // We limit the argument of tanh, because some GLSL implementations (e.g.
+        // AMD Radeon RX 5700 XT) overflow when computing it and yield NaN.
         pseudoMirrorDepth = sqr(max(0, dot(viewDir, sunDirection))) *
-                               tanh(150 * (newViewElev - horizElev) / (PI/2 - horizElev));
+                               tanh(min(10, 150 * (newViewElev - horizElev) / (PI/2 - horizElev)));
     }
 
     CONST float cosSunZenithAngle =dot(zenith,sunDirection);

diff --git a/atmosphere/default/shaders/single-scattering-eclipsed/on-the-fly/0/aerosols/render.frag b/atmosphere/default/shaders/single-scattering-eclipsed/on-the-fly/0/aerosols/render.frag
@@ -286,8 +286,10 @@ void main()
         // The first factor here, with dot(view,sun), results in removal of the
         // forward scattering peak. The second factor, with tanh, makes the
         // transition near sunset from a bit above horizon to a bit below smoother.
+        // We limit the argument of tanh, because some GLSL implementations (e.g.
+        // AMD Radeon RX 5700 XT) overflow when computing it and yield NaN.
         pseudoMirrorDepth = sqr(max(0, dot(viewDir, sunDirection))) *
-                               tanh(150 * (newViewElev - horizElev) / (PI/2 - horizElev));
+                               tanh(min(10, 150 * (newViewElev - horizElev) / (PI/2 - horizElev)));
     }
 
     CONST float cosSunZenithAngle =dot(zenith,sunDirection);

diff --git a/atmosphere/default/shaders/single-scattering-eclipsed/on-the-fly/0/molecules/render.frag b/atmosphere/default/shaders/single-scattering-eclipsed/on-the-fly/0/molecules/render.frag
@@ -286,8 +286,10 @@ void main()
         // The first factor here, with dot(view,sun), results in removal of the
         // forward scattering peak. The second factor, with tanh, makes the
         // transition near sunset from a bit above horizon to a bit below smoother.
+        // We limit the argument of tanh, because some GLSL implementations (e.g.
+        // AMD Radeon RX 5700 XT) overflow when computing it and yield NaN.
         pseudoMirrorDepth = sqr(max(0, dot(viewDir, sunDirection))) *
-                               tanh(150 * (newViewElev - horizElev) / (PI/2 - horizElev));
+                               tanh(min(10, 150 * (newViewElev - horizElev) / (PI/2 - horizElev)));
     }
 
     CONST float cosSunZenithAngle =dot(zenith,sunDirection);

diff --git a/atmosphere/default/shaders/single-scattering-eclipsed/on-the-fly/1/aerosols/render.frag b/atmosphere/default/shaders/single-scattering-eclipsed/on-the-fly/1/aerosols/render.frag
@@ -286,8 +286,10 @@ void main()
         // The first factor here, with dot(view,sun), results in removal of the
         // forward scattering peak. The second factor, with tanh, makes the
         // transition near sunset from a bit above horizon to a bit below smoother.
+        // We limit the argument of tanh, because some GLSL implementations (e.g.
+        // AMD Radeon RX 5700 XT) overflow when computing it and yield NaN.
         pseudoMirrorDepth = sqr(max(0, dot(viewDir, sunDirection))) *
-                               tanh(150 * (newViewElev - horizElev) / (PI/2 - horizElev));
+                               tanh(min(10, 150 * (newViewElev - horizElev) / (PI/2 - horizElev)));
     }
 
     CONST float cosSunZenithAngle =dot(zenith,sunDirection);

diff --git a/atmosphere/default/shaders/single-scattering-eclipsed/on-the-fly/1/molecules/render.frag b/atmosphere/default/shaders/single-scattering-eclipsed/on-the-fly/1/molecules/render.frag
@@ -286,8 +286,10 @@ void main()
         // The first factor here, with dot(view,sun), results in removal of the
         // forward scattering peak. The second factor, with tanh, makes the
         // transition near sunset from a bit above horizon to a bit below smoother.
+        // We limit the argument of tanh, because some GLSL implementations (e.g.
+        // AMD Radeon RX 5700 XT) overflow when computing it and yield NaN.
         pseudoMirrorDepth = sqr(max(0, dot(viewDir, sunDirection))) *
-                               tanh(150 * (newViewElev - horizElev) / (PI/2 - horizElev));
+                               tanh(min(10, 150 * (newViewElev - horizElev) / (PI/2 - horizElev)));
     }
 
     CONST float cosSunZenithAngle =dot(zenith,sunDirection);

diff --git a/atmosphere/default/shaders/single-scattering-eclipsed/on-the-fly/2/aerosols/render.frag b/atmosphere/default/shaders/single-scattering-eclipsed/on-the-fly/2/aerosols/render.frag
@@ -286,8 +286,10 @@ void main()
         // The first factor here, with dot(view,sun), results in removal of the
         // forward scattering peak. The second factor, with tanh, makes the
         // transition near sunset from a bit above horizon to a bit below smoother.
+        // We limit the argument of tanh, because some GLSL implementations (e.g.
+        // AMD Radeon RX 5700 XT) overflow when computing it and yield NaN.
         pseudoMirrorDepth = sqr(max(0, dot(viewDir, sunDirection))) *
-                               tanh(150 * (newViewElev - horizElev) / (PI/2 - horizElev));
+                               tanh(min(10, 150 * (newViewElev - horizElev) / (PI/2 - horizElev)));
     }
 
     CONST float cosSunZenithAngle =dot(zenith,sunDirection);

diff --git a/atmosphere/default/shaders/single-scattering-eclipsed/on-the-fly/2/molecules/render.frag b/atmosphere/default/shaders/single-scattering-eclipsed/on-the-fly/2/molecules/render.frag
@@ -286,8 +286,10 @@ void main()
         // The first factor here, with dot(view,sun), results in removal of the
         // forward scattering peak. The second factor, with tanh, makes the
         // transition near sunset from a bit above horizon to a bit below smoother.
+        // We limit the argument of tanh, because some GLSL implementations (e.g.
+        // AMD Radeon RX 5700 XT) overflow when computing it and yield NaN.
         pseudoMirrorDepth = sqr(max(0, dot(viewDir, sunDirection))) *
-                               tanh(150 * (newViewElev - horizElev) / (PI/2 - horizElev));
+                               tanh(min(10, 150 * (newViewElev - horizElev) / (PI/2 - horizElev)));
     }
 
     CONST float cosSunZenithAngle =dot(zenith,sunDirection);

diff --git a/atmosphere/default/shaders/single-scattering-eclipsed/on-the-fly/3/aerosols/render.frag b/atmosphere/default/shaders/single-scattering-eclipsed/on-the-fly/3/aerosols/render.frag
@@ -286,8 +286,10 @@ void main()
         // The first factor here, with dot(view,sun), results in removal of the
         // forward scattering peak. The second factor, with tanh, makes the
         // transition near sunset from a bit above horizon to a bit below smoother.
+        // We limit the argument of tanh, because some GLSL implementations (e.g.
+        // AMD Radeon RX 5700 XT) overflow when computing it and yield NaN.
         pseudoMirrorDepth = sqr(max(0, dot(viewDir, sunDirection))) *
-                               tanh(150 * (newViewElev - horizElev) / (PI/2 - horizElev));
+                               tanh(min(10, 150 * (newViewElev - horizElev) / (PI/2 - horizElev)));
     }
 
     CONST float cosSunZenithAngle =dot(zenith,sunDirection);

diff --git a/atmosphere/default/shaders/single-scattering-eclipsed/on-the-fly/3/molecules/render.frag b/atmosphere/default/shaders/single-scattering-eclipsed/on-the-fly/3/molecules/render.frag
@@ -286,8 +286,10 @@ void main()
         // The first factor here, with dot(view,sun), results in removal of the
         // forward scattering peak. The second factor, with tanh, makes the
         // transition near sunset from a bit above horizon to a bit below smoother.
+        // We limit the argument of tanh, because some GLSL implementations (e.g.
+        // AMD Radeon RX 5700 XT) overflow when computing it and yield NaN.
         pseudoMirrorDepth = sqr(max(0, dot(viewDir, sunDirection))) *
-                               tanh(150 * (newViewElev - horizElev) / (PI/2 - horizElev));
+                               tanh(min(10, 150 * (newViewElev - horizElev) / (PI/2 - horizElev)));
     }
 
     CONST float cosSunZenithAngle =dot(zenith,sunDirection);

diff --git a/atmosphere/default/shaders/single-scattering-eclipsed/precomputed/aerosols/render.frag b/atmosphere/default/shaders/single-scattering-eclipsed/precomputed/aerosols/render.frag
@@ -286,8 +286,10 @@ void main()
         // The first factor here, with dot(view,sun), results in removal of the
         // forward scattering peak. The second factor, with tanh, makes the
         // transition near sunset from a bit above horizon to a bit below smoother.
+        // We limit the argument of tanh, because some GLSL implementations (e.g.
+        // AMD Radeon RX 5700 XT) overflow when computing it and yield NaN.
         pseudoMirrorDepth = sqr(max(0, dot(viewDir, sunDirection))) *
-                               tanh(150 * (newViewElev - horizElev) / (PI/2 - horizElev));
+                               tanh(min(10, 150 * (newViewElev - horizElev) / (PI/2 - horizElev)));
     }
 
     CONST float cosSunZenithAngle =dot(zenith,sunDirection);

diff --git a/atmosphere/default/shaders/single-scattering-eclipsed/precomputed/molecules/render.frag b/atmosphere/default/shaders/single-scattering-eclipsed/precomputed/molecules/render.frag
@@ -286,8 +286,10 @@ void main()
         // The first factor here, with dot(view,sun), results in removal of the
         // forward scattering peak. The second factor, with tanh, makes the
         // transition near sunset from a bit above horizon to a bit below smoother.
+        // We limit the argument of tanh, because some GLSL implementations (e.g.
+        // AMD Radeon RX 5700 XT) overflow when computing it and yield NaN.
         pseudoMirrorDepth = sqr(max(0, dot(viewDir, sunDirection))) *
-                               tanh(150 * (newViewElev - horizElev) / (PI/2 - horizElev));
+                               tanh(min(10, 150 * (newViewElev - horizElev) / (PI/2 - horizElev)));
     }
 
     CONST float cosSunZenithAngle =dot(zenith,sunDirection);

diff --git a/atmosphere/default/shaders/single-scattering/on-the-fly/0/aerosols/render.frag b/atmosphere/default/shaders/single-scattering/on-the-fly/0/aerosols/render.frag
@@ -286,8 +286,10 @@ void main()
         // The first factor here, with dot(view,sun), results in removal of the
         // forward scattering peak. The second factor, with tanh, makes the
         // transition near sunset from a bit above horizon to a bit below smoother.
+        // We limit the argument of tanh, because some GLSL implementations (e.g.
+        // AMD Radeon RX 5700 XT) overflow when computing it and yield NaN.
         pseudoMirrorDepth = sqr(max(0, dot(viewDir, sunDirection))) *
-                               tanh(150 * (newViewElev - horizElev) / (PI/2 - horizElev));
+                               tanh(min(10, 150 * (newViewElev - horizElev) / (PI/2 - horizElev)));
     }
 
     CONST float cosSunZenithAngle =dot(zenith,sunDirection);

diff --git a/atmosphere/default/shaders/single-scattering/on-the-fly/0/molecules/render.frag b/atmosphere/default/shaders/single-scattering/on-the-fly/0/molecules/render.frag
@@ -286,8 +286,10 @@ void main()
         // The first factor here, with dot(view,sun), results in removal of the
         // forward scattering peak. The second factor, with tanh, makes the
         // transition near sunset from a bit above horizon to a bit below smoother.
+        // We limit the argument of tanh, because some GLSL implementations (e.g.
+        // AMD Radeon RX 5700 XT) overflow when computing it and yield NaN.
         pseudoMirrorDepth = sqr(max(0, dot(viewDir, sunDirection))) *
-                               tanh(150 * (newViewElev - horizElev) / (PI/2 - horizElev));
+                               tanh(min(10, 150 * (newViewElev - horizElev) / (PI/2 - horizElev)));
     }
 
     CONST float cosSunZenithAngle =dot(zenith,sunDirection);

diff --git a/atmosphere/default/shaders/single-scattering/on-the-fly/1/aerosols/render.frag b/atmosphere/default/shaders/single-scattering/on-the-fly/1/aerosols/render.frag
@@ -286,8 +286,10 @@ void main()
         // The first factor here, with dot(view,sun), results in removal of the
         // forward scattering peak. The second factor, with tanh, makes the
         // transition near sunset from a bit above horizon to a bit below smoother.
+        // We limit the argument of tanh, because some GLSL implementations (e.g.
+        // AMD Radeon RX 5700 XT) overflow when computing it and yield NaN.
         pseudoMirrorDepth = sqr(max(0, dot(viewDir, sunDirection))) *
-                               tanh(150 * (newViewElev - horizElev) / (PI/2 - horizElev));
+                               tanh(min(10, 150 * (newViewElev - horizElev) / (PI/2 - horizElev)));
     }
 
     CONST float cosSunZenithAngle =dot(zenith,sunDirection);

diff --git a/atmosphere/default/shaders/single-scattering/on-the-fly/1/molecules/render.frag b/atmosphere/default/shaders/single-scattering/on-the-fly/1/molecules/render.frag
@@ -286,8 +286,10 @@ void main()
         // The first factor here, with dot(view,sun), results in removal of the
         // forward scattering peak. The second factor, with tanh, makes the
         // transition near sunset from a bit above horizon to a bit below smoother.
+        // We limit the argument of tanh, because some GLSL implementations (e.g.
+        // AMD Radeon RX 5700 XT) overflow when computing it and yield NaN.
         pseudoMirrorDepth = sqr(max(0, dot(viewDir, sunDirection))) *
-                               tanh(150 * (newViewElev - horizElev) / (PI/2 - horizElev));
+                               tanh(min(10, 150 * (newViewElev - horizElev) / (PI/2 - horizElev)));
     }
 
     CONST float cosSunZenithAngle =dot(zenith,sunDirection);

diff --git a/atmosphere/default/shaders/single-scattering/on-the-fly/2/aerosols/render.frag b/atmosphere/default/shaders/single-scattering/on-the-fly/2/aerosols/render.frag
@@ -286,8 +286,10 @@ void main()
         // The first factor here, with dot(view,sun), results in removal of the
         // forward scattering peak. The second factor, with tanh, makes the
         // transition near sunset from a bit above horizon to a bit below smoother.
+        // We limit the argument of tanh, because some GLSL implementations (e.g.
+        // AMD Radeon RX 5700 XT) overflow when computing it and yield NaN.
         pseudoMirrorDepth = sqr(max(0, dot(viewDir, sunDirection))) *
-                               tanh(150 * (newViewElev - horizElev) / (PI/2 - horizElev));
+                               tanh(min(10, 150 * (newViewElev - horizElev) / (PI/2 - horizElev)));
     }
 
     CONST float cosSunZenithAngle =dot(zenith,sunDirection);

diff --git a/atmosphere/default/shaders/single-scattering/on-the-fly/2/molecules/render.frag b/atmosphere/default/shaders/single-scattering/on-the-fly/2/molecules/render.frag
@@ -286,8 +286,10 @@ void main()
         // The first factor here, with dot(view,sun), results in removal of the
         // forward scattering peak. The second factor, with tanh, makes the
         // transition near sunset from a bit above horizon to a bit below smoother.
+        // We limit the argument of tanh, because some GLSL implementations (e.g.
+        // AMD Radeon RX 5700 XT) overflow when computing it and yield NaN.
         pseudoMirrorDepth = sqr(max(0, dot(viewDir, sunDirection))) *
-                               tanh(150 * (newViewElev - horizElev) / (PI/2 - horizElev));
+                               tanh(min(10, 150 * (newViewElev - horizElev) / (PI/2 - horizElev)));
     }
 
     CONST float cosSunZenithAngle =dot(zenith,sunDirection);

diff --git a/atmosphere/default/shaders/single-scattering/on-the-fly/3/aerosols/render.frag b/atmosphere/default/shaders/single-scattering/on-the-fly/3/aerosols/render.frag
@@ -286,8 +286,10 @@ void main()
         // The first factor here, with dot(view,sun), results in removal of the
         // forward scattering peak. The second factor, with tanh, makes the
         // transition near sunset from a bit above horizon to a bit below smoother.
+        // We limit the argument of tanh, because some GLSL implementations (e.g.
+        // AMD Radeon RX 5700 XT) overflow when computing it and yield NaN.
         pseudoMirrorDepth = sqr(max(0, dot(viewDir, sunDirection))) *
-                               tanh(150 * (newViewElev - horizElev) / (PI/2 - horizElev));
+                               tanh(min(10, 150 * (newViewElev - horizElev) / (PI/2 - horizElev)));
     }
 
     CONST float cosSunZenithAngle =dot(zenith,sunDirection);

diff --git a/atmosphere/default/shaders/single-scattering/on-the-fly/3/molecules/render.frag b/atmosphere/default/shaders/single-scattering/on-the-fly/3/molecules/render.frag
@@ -286,8 +286,10 @@ void main()
         // The first factor here, with dot(view,sun), results in removal of the
         // forward scattering peak. The second factor, with tanh, makes the
         // transition near sunset from a bit above horizon to a bit below smoother.
+        // We limit the argument of tanh, because some GLSL implementations (e.g.
+        // AMD Radeon RX 5700 XT) overflow when computing it and yield NaN.
         pseudoMirrorDepth = sqr(max(0, dot(viewDir, sunDirection))) *
-                               tanh(150 * (newViewElev - horizElev) / (PI/2 - horizElev));
+                               tanh(min(10, 150 * (newViewElev - horizElev) / (PI/2 - horizElev)));
     }
 
     CONST float cosSunZenithAngle =dot(zenith,sunDirection);

diff --git a/atmosphere/default/shaders/single-scattering/precomputed/aerosols/render.frag b/atmosphere/default/shaders/single-scattering/precomputed/aerosols/render.frag
@@ -286,8 +286,10 @@ void main()
         // The first factor here, with dot(view,sun), results in removal of the
         // forward scattering peak. The second factor, with tanh, makes the
         // transition near sunset from a bit above horizon to a bit below smoother.
+        // We limit the argument of tanh, because some GLSL implementations (e.g.
+        // AMD Radeon RX 5700 XT) overflow when computing it and yield NaN.
         pseudoMirrorDepth = sqr(max(0, dot(viewDir, sunDirection))) *
-                               tanh(150 * (newViewElev - horizElev) / (PI/2 - horizElev));
+                               tanh(min(10, 150 * (newViewElev - horizElev) / (PI/2 - horizElev)));
     }
 
     CONST float cosSunZenithAngle =dot(zenith,sunDirection);